Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/events/keycodes/platform_key_map_win.cc

Issue 2733283002: Require explicit selection of traits for LazyInstance (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« extensions/browser/browser_context_keyed_api_factory.h ('K') | « ui/base/l10n/time_format.cc ('k') | ui/gfx/font_list.cc » ('j') | ui/gfx/icc_profile.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/keycodes/platform_key_map_win.cc
diff --git a/ui/events/keycodes/platform_key_map_win.cc b/ui/events/keycodes/platform_key_map_win.cc
index 32b544e31ca8b72463fc8b75052ff91984cc3b5b..cdd97752f7d85f831cdfc9089eb751dbd30fd3f6 100644
--- a/ui/events/keycodes/platform_key_map_win.cc
+++ b/ui/events/keycodes/platform_key_map_win.cc
@@ -262,7 +262,7 @@ void CleanupKeyMapTls(void* data) {
}
struct PlatformKeyMapInstanceTlsTraits
- : public base::DefaultLazyInstanceTraits<base::ThreadLocalStorage::Slot> {
+ : public base::LazyInstanceTraitsBase<base::ThreadLocalStorage::Slot> {
Nico 2017/03/07 21:43:02 same question as the other "wait" comment
scottmg 2017/03/07 21:56:30 Done.
static base::ThreadLocalStorage::Slot* New(void* instance) {
// Use placement new to initialize our instance in our preallocated space.
// TODO(chongz): Use std::default_delete instead of providing own function.
« extensions/browser/browser_context_keyed_api_factory.h ('K') | « ui/base/l10n/time_format.cc ('k') | ui/gfx/font_list.cc » ('j') | ui/gfx/icc_profile.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698