Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: extensions/browser/browser_context_keyed_api_factory.h

Issue 2733283002: Require explicit selection of traits for LazyInstance (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/browser_context_keyed_api_factory.h
diff --git a/extensions/browser/browser_context_keyed_api_factory.h b/extensions/browser/browser_context_keyed_api_factory.h
index 47a19a0d47fecedeec2f32b5239d6c37c910e6be..1316c08875870e9263f000909b929389661d860b 100644
--- a/extensions/browser/browser_context_keyed_api_factory.h
+++ b/extensions/browser/browser_context_keyed_api_factory.h
@@ -56,8 +56,8 @@ class BrowserContextKeyedAPI : public KeyedService {
// };
//
// In the cc file, provide the implementation, e.g.:
- // static base::LazyInstance<BrowserContextKeyedAPIFactory<HistoryAPI> >
- // g_factory = LAZY_INSTANCE_INITIALIZER;
+ // static base::LazyInstance<BrowserContextKeyedAPIFactory<HistoryAPI>>::
+ // DestructorAtExit g_factory = LAZY_INSTANCE_INITIALIZER;
Nico 2017/03/07 21:43:02 should this recommend the leaky version?
scottmg 2017/03/07 21:56:30 I changed the lazy_instance.h one to recommend lea
//
// // static
// BrowserContextKeyedAPIFactory<HistoryAPI>*

Powered by Google App Engine
This is Rietveld 408576698