[Chromecast] Add new crash keys from chrome/common.

[Chromecast] Add new crash keys from chrome/common.

Whenever new crash keys are registered in chrome/common, we must
copy them in chromecast/crash/; otherwise a DCHECK fails
whenever any component tries to set a crash key value that has
not been registered.

BUG=598854
TEST=Cherry-pick to internal branch, build internal apk, run on device

Review-Url: https://codereview.chromium.org/2733123002
Cr-Commit-Position: refs/heads/master@{#455582}
Committed: https://chromium.googlesource.com/chromium/src/+/71906ce9957150b6fab9e906bfce22285eccc6f9

[Simeon, 2017-03-07 01:21:17]

sanfin@chromium.org changed reviewers:
+ rsesek@chromium.org, slan@chromium.org

[Simeon, 2017-03-07 01:21:18]

This should fix the crashes on the Chromecast master branch until rsesek@
implements http://crbug.com/598854. I also added a message in
chrome/common/crash_keys.cc to inform people adding crash keys there to also add
them in our file.

[sadrul, 2017-03-07 01:29:14]

This is a little bit unfortunate. Maybe we can have a better solution so we
don't need to duplicate the keys in various places. See some discussion at
https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/2NVBSWHUAP0...

/cc+ jamescook@ FYI

[James Cook, 2017-03-07 16:33:31]

On 2017/03/07 01:29:14, sadrul wrote:
> This is a little bit unfortunate. Maybe we can have a better solution so we
> don't need to duplicate the keys in various places. See some discussion at
>
https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/2NVBSWHUAP0...
> 
> /cc+ jamescook@ FYI

FYI - Per crbug.com/598854 copy/pasting is the recommended way of doing things
until the pre-registration requirement is removed.

[Simeon, 2017-03-08 17:03:43]

Ping. I would like to unblock development on our master branch :)

[Robert Sesek, 2017-03-08 18:02:50]

LGTM. Sorry for the slowness (perf)

[halliwell, 2017-03-08 18:08:15]

On 2017/03/08 18:02:50, Robert Sesek wrote:
> LGTM. Sorry for the slowness (perf)

lgtm

[Simeon, 2017-03-08 18:24:39]

The CQ bit was checked by sanfin@chromium.org

[commit-bot: I haz the power, 2017-03-08 18:25:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 18:35:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 18:35:09]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Simeon, 2017-03-08 21:37:09]

The CQ bit was checked by sanfin@chromium.org

[Simeon, 2017-03-08 21:37:10]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
halliwell@chromium.org
Link to the patchset: https://codereview.chromium.org/2733123002/#ps20001
(title: "Fix gn header check")

[commit-bot: I haz the power, 2017-03-08 21:37:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 23:11:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489009029896220,
"parent_rev": "fb103a64dfc5badb129712fc8b018c3fe4b993cc", "commit_rev":
"71906ce9957150b6fab9e906bfce22285eccc6f9"}

[commit-bot: I haz the power, 2017-03-08 23:12:27]

Description was changed from

==========
[Chromecast] Add new crash keys from chrome/common.

Whenever new crash keys are registered in chrome/common, we must
copy them in chromecast/crash/; otherwise a DCHECK fails
whenever any component tries to set a crash key value that has
not been registered.

BUG=598854
TEST=Cherry-pick to internal branch, build internal apk, run on device
==========

to

==========
[Chromecast] Add new crash keys from chrome/common.

Whenever new crash keys are registered in chrome/common, we must
copy them in chromecast/crash/; otherwise a DCHECK fails
whenever any component tries to set a crash key value that has
not been registered.

BUG=598854
TEST=Cherry-pick to internal branch, build internal apk, run on device

Review-Url: https://codereview.chromium.org/2733123002
Cr-Commit-Position: refs/heads/master@{#455582}
Committed:
https://chromium.googlesource.com/chromium/src/+/71906ce9957150b6fab9e906bfce...
==========

[commit-bot: I haz the power, 2017-03-08 23:12:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/71906ce9957150b6fab9e906bfce...