Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2733113002: Rename updateWidgetGeometry methods to updateGeometry. (Closed)

Created:
3 years, 9 months ago by joelhockey
Modified:
3 years, 9 months ago
Reviewers:
haraken, slangley, sashab
CC:
blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, kinuko+watch, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename updateWidgetGeometry methods to updateGeometry. BUG=697351 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2733113002 Cr-Commit-Position: refs/heads/master@{#455285} Committed: https://chromium.googlesource.com/chromium/src/+/1078f602af4b16ac905fbb82c3f52c7b52fc15dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -33 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 4 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 8 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPart.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPart.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/FrameViewBase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
joelhockey
3 years, 9 months ago (2017-03-07 00:12:37 UTC) #3
joelhockey
3 years, 9 months ago (2017-03-07 00:13:12 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-03-07 03:34:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733113002/1
3 years, 9 months ago (2017-03-07 03:45:35 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/379145)
3 years, 9 months ago (2017-03-07 05:26:58 UTC) #12
sashab
I'm getting that exact same error on my patches: https://codereview.chromium.org/2718313002/ Flaky test?
3 years, 9 months ago (2017-03-07 05:35:06 UTC) #13
pdr.
On 2017/03/07 at 05:35:06, sashab wrote: > I'm getting that exact same error on my ...
3 years, 9 months ago (2017-03-07 05:46:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733113002/1
3 years, 9 months ago (2017-03-07 21:26:05 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 23:28:10 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1078f602af4b16ac905fbb82c3f5...

Powered by Google App Engine
This is Rietveld 408576698