Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: components/plugins/renderer/webview_plugin.h

Issue 2733083004: Emit error events if the loading of an object element failed (Closed)
Patch Set: Emit error events if the loading of an object element failed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/plugins/renderer/webview_plugin.h
diff --git a/components/plugins/renderer/webview_plugin.h b/components/plugins/renderer/webview_plugin.h
index 7f4ad1045a850bad918d6c85c898a0247a61a71a..aab49938fd6e0d7218b426b878e0ca9b065b019a 100644
--- a/components/plugins/renderer/webview_plugin.h
+++ b/components/plugins/renderer/webview_plugin.h
@@ -55,6 +55,8 @@ class WebViewPlugin : public blink::WebPlugin,
// Called when the unobscured rect of the plugin is updated.
virtual void OnUnobscuredRectUpdate(const gfx::Rect& unobscured_rect) {}
+
+ virtual bool IsErrorplaceholder() = 0;
tommycli 2017/04/03 22:15:49 Yes, to echo bauerb, this should be IsErrorPlaceho
George Joseph 2017/04/04 23:37:41 Done.
};
// Convenience method to set up a new WebViewPlugin using |preferences|
@@ -84,6 +86,8 @@ class WebViewPlugin : public blink::WebPlugin,
v8::Local<v8::Object> v8ScriptableObject(v8::Isolate* isolate) override;
+ bool isErrorplaceholder() override;
tommycli 2017/04/03 22:15:49 and isErrorPlaceholder here
George Joseph 2017/04/04 23:37:41 Done.
+
void updateAllLifecyclePhases() override;
void paint(blink::WebCanvas* canvas, const blink::WebRect& rect) override;

Powered by Google App Engine
This is Rietveld 408576698