Emit error events if the loading of an object element failed

components/plugins/renderer/webview_plugin.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PLUGINS_RENDERER_WEBVIEW_PLUGIN_H_
 #define COMPONENTS_PLUGINS_RENDERER_WEBVIEW_PLUGIN_H_
 
 #include <list>
 #include <memory>
 
@@ skipping 37 matching lines @@
 
     // Called when the WebViewPlugin is destroyed.
     virtual void PluginDestroyed() = 0;
 
     // Called to enable JavaScript pass-through to a throttled plugin, which is
     // loaded but idle. Doesn't work for blocked plugins, which is not loaded.
     virtual v8::Local<v8::Object> GetV8ScriptableObject(v8::Isolate*) const = 0;
 
     // Called when the unobscured rect of the plugin is updated.
     virtual void OnUnobscuredRectUpdate(const gfx::Rect& unobscured_rect) {}
+
+    virtual bool IsErrorplaceholder() = 0;

[tommycli, 2017/04/03 22:15:49]

Yes, to echo bauerb, this should be IsErrorPlaceholder()

[George Joseph, 2017/04/04 23:37:41]

Done.

   };
 
   // Convenience method to set up a new WebViewPlugin using |preferences|
   // and displaying |html_data|. |url| should be a (fake) data:text/html URL;
   // it is only used for navigation and never actually resolved.
   static WebViewPlugin* Create(content::RenderView* render_view,
                                Delegate* delegate,
                                const content::WebPreferences& preferences,
                                const std::string& html_data,
                                const GURL& url);
 
   blink::WebView* web_view() { return web_view_helper_.web_view(); }
 
   const blink::WebString& old_title() const { return old_title_; }
 
   // When loading a plugin document (i.e. a full page plugin not embedded in
   // another page), we save all data that has been received, and replay it with
   // this method on the actual plugin.
   void ReplayReceivedData(blink::WebPlugin* plugin);
 
   // WebPlugin methods:
   blink::WebPluginContainer* container() const override;
   // The WebViewPlugin, by design, never fails to initialize. It's used to
   // display placeholders and error messages, so it must never fail.
   bool initialize(blink::WebPluginContainer*) override;
   void destroy() override;
 
   v8::Local<v8::Object> v8ScriptableObject(v8::Isolate* isolate) override;
 
+  bool isErrorplaceholder() override;

[tommycli, 2017/04/03 22:15:49]

and isErrorPlaceholder here

[George Joseph, 2017/04/04 23:37:41]

Done.

+
   void updateAllLifecyclePhases() override;
   void paint(blink::WebCanvas* canvas, const blink::WebRect& rect) override;
 
   // Coordinates are relative to the containing window.
   void updateGeometry(const blink::WebRect& window_rect,
                       const blink::WebRect& clip_rect,
                       const blink::WebRect& unobscured_rect,
                       const blink::WebVector<blink::WebRect>& cut_outs_rects,
                       bool is_visible) override;
 
@@ skipping 79 matching lines @@
     // Owned by us, deleted via |close()|.
     blink::WebView* web_view_;
   };
   WebViewHelper web_view_helper_;
 
   // Should be invalidated when destroy() is called.
   base::WeakPtrFactory<WebViewPlugin> weak_factory_;
 };
 
 #endif  // COMPONENTS_PLUGINS_RENDERER_WEBVIEW_PLUGIN_H_