components/plugins/renderer/webview_plugin.cc - Issue 2733083004: Emit error events if the loading of an object element failed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/webview_plugin.cc

Issue 2733083004: Emit error events if the loading of an object element failed (Closed)

Patch Set: Emit error events if the loading of an object element failed Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/plugins/renderer/webview_plugin.cc

diff --git a/components/plugins/renderer/webview_plugin.cc b/components/plugins/renderer/webview_plugin.cc

index 075515a0779ff784b51c27f377e22cf38aba4a59..1f72462eb9991e059966e2d93d50545506244b34 100644

--- a/components/plugins/renderer/webview_plugin.cc

+++ b/components/plugins/renderer/webview_plugin.cc

@@ -142,6 +142,13 @@ v8::Local<v8::Object> WebViewPlugin::v8ScriptableObject(v8::Isolate* isolate) {

return delegate_->GetV8ScriptableObject(isolate);

}

+bool WebViewPlugin::isErrorPlaceholder() {

+ if (!delegate_)

+ return false;

+ return delegate_->isErrorPlaceholder();

void WebViewPlugin::updateAllLifecyclePhases() {

web_view()->updateAllLifecyclePhases();

}