third_party/WebKit/public/web/WebPlugin.h - Issue 2733083004: Emit error events if the loading of an object element failed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/WebPlugin.h

Issue 2733083004: Emit error events if the loading of an object element failed (Closed)

Patch Set: Emit error events if the loading of an object element failed Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/public/web/WebPlugin.h

diff --git a/third_party/WebKit/public/web/WebPlugin.h b/third_party/WebKit/public/web/WebPlugin.h

index 6e6403a7a6a5e5ce5129610d46044c0bbe83a7b6..ec0f94aabb8649280f701ee3947df4e31ec67861 100644

--- a/third_party/WebKit/public/web/WebPlugin.h

+++ b/third_party/WebKit/public/web/WebPlugin.h

@@ -133,6 +133,7 @@ class WebPlugin {

virtual void didReceiveData(const char* data, int dataLength) = 0;

virtual void didFinishLoading() = 0;

virtual void didFailLoading(const WebURLError&) = 0;

+ virtual bool isErrorPlaceholder() { return false; };

Bernhard Bauer 2017/03/30 09:08:28 Move this down, maybe to isPlaceholder()? The meth

// Printing interface.

// Whether the plugin supports its own paginated print. The other print