Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2733083002: MD Settings: fix setting-subpage icon color value. (Closed)

Created:
3 years, 9 months ago by scottchen
Modified:
3 years, 9 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix setting-subpage icon color value. BUG=654962 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2733083002 Cr-Commit-Position: refs/heads/master@{#455313} Committed: https://chromium.googlesource.com/chromium/src/+/17218793515d69f9512895ff9b2e71f89d57982f

Patch Set 1 #

Total comments: 2

Patch Set 2 : removing unnecessary style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/resources/settings/settings_page/settings_subpage.html View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
scottchen
3 years, 9 months ago (2017-03-06 20:27:00 UTC) #3
dschuyler
https://codereview.chromium.org/2733083002/diff/1/chrome/browser/resources/settings/settings_page/settings_subpage.html File chrome/browser/resources/settings/settings_page/settings_subpage.html (right): https://codereview.chromium.org/2733083002/diff/1/chrome/browser/resources/settings/settings_page/settings_subpage.html#newcode17 chrome/browser/resources/settings/settings_page/settings_subpage.html:17: --iron-icon-fill-color: var(--paper-grey-600); Will removing this line and letting the ...
3 years, 9 months ago (2017-03-06 23:52:21 UTC) #4
scottchen
https://codereview.chromium.org/2733083002/diff/1/chrome/browser/resources/settings/settings_page/settings_subpage.html File chrome/browser/resources/settings/settings_page/settings_subpage.html (right): https://codereview.chromium.org/2733083002/diff/1/chrome/browser/resources/settings/settings_page/settings_subpage.html#newcode17 chrome/browser/resources/settings/settings_page/settings_subpage.html:17: --iron-icon-fill-color: var(--paper-grey-600); On 2017/03/06 23:52:21, dschuyler wrote: > Will ...
3 years, 9 months ago (2017-03-07 22:04:53 UTC) #5
dschuyler
lgtm
3 years, 9 months ago (2017-03-07 22:06:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733083002/20001
3 years, 9 months ago (2017-03-07 23:24:24 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 00:42:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/17218793515d69f9512895ff9b2e...

Powered by Google App Engine
This is Rietveld 408576698