Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2733013002: Fix chromium-style warning for auto in jpeg_decode_accelerator_unittest (Closed)

Created:
3 years, 9 months ago by fwang
Modified:
3 years, 9 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, tonikitoo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix chromium-style warning for auto in jpeg_decode_accelerator_unittest This CL fixes the following warnings: media/gpu/jpeg_decode_accelerator_unittest.cc:478:8: warning: for (const auto& image : g_env->image_data_user_) { ^~~~~~~~~~~ auto* const media/gpu/jpeg_decode_accelerator_unittest.cc:486:8: warning: for (const auto& image : g_env->image_data_user_) { ^~~~~~~~~~~ auto* const 2 warnings generated. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2733013002 Cr-Commit-Position: refs/heads/master@{#454897} Committed: https://chromium.googlesource.com/chromium/src/+/fbb72741a769f768299bdeb7865dac5785ce1fd9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/gpu/jpeg_decode_accelerator_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
fwang
PTAL
3 years, 9 months ago (2017-03-06 14:25:39 UTC) #5
DaleCurtis
lgtm
3 years, 9 months ago (2017-03-06 17:43:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733013002/1
3 years, 9 months ago (2017-03-06 18:28:03 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 18:35:35 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fbb72741a769f768299bdeb7865d...

Powered by Google App Engine
This is Rietveld 408576698