Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2732993002: Display menu icon in iPhone X+ in landscape (Closed)

Created:
3 years, 9 months ago by gambard
Modified:
3 years, 9 months ago
Reviewers:
jif
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, stkhapugin, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Display menu icon in iPhone X+ in landscape BUG=697837, 698726 Review-Url: https://codereview.chromium.org/2732993002 Cr-Commit-Position: refs/heads/master@{#454861} Committed: https://chromium.googlesource.com/chromium/src/+/70079b5955de2a047669c39938839851fb107b44

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
gambard
PTAL.
3 years, 9 months ago (2017-03-06 12:56:08 UTC) #2
jif
lgtm
3 years, 9 months ago (2017-03-06 13:26:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732993002/1
3 years, 9 months ago (2017-03-06 13:26:44 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 13:38:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/70079b5955de2a047669c3993883...

Powered by Google App Engine
This is Rietveld 408576698