Keep state even if AndroidManagement check returns MANAGED or ERROR.

Keep state even if AndroidManagement check returns MANAGED or ERROR.

This is the first CL to fix the state machine in ArcSessionManager.
With this CL, even if AndroidManagement check returns MANAGED or ERROR,
the state will be left as is (= CHECKING_ANDROID_MANAGEMENT),
expecting more action is done later.
On clicking RETRY button, the management check should re-run.
On giving up the check, Google Play Store enabled preference
should be set to false, which should trigger RequestDisable().

Along with the change, several refactoring is done.
- Renamed the function. (Removed "Arc" prefix, because it is
  ArcSessionManager's private method so redundant.)
- Extract StartBackgroundAndroidManagementCheck() method, to be
  consistent non-background method.

BUG=657687
BUG=b/31079732
TEST=Ran trybots.

Review-Url: https://codereview.chromium.org/2732983002
Cr-Commit-Position: refs/heads/master@{#455047}
Committed: https://chromium.googlesource.com/chromium/src/+/20e3c142aad1cc086b840a647f0fce829299290e

[hidehiko, 2017-03-06 11:15:36]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 11:15:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 11:53:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 11:53:13]

Dry run: This issue passed the CQ dry run.

[hidehiko, 2017-03-06 11:57:55]

hidehiko@chromium.org changed reviewers:
+ yusukes@chromium.org

[hidehiko, 2017-03-06 11:57:56]

PTAL.

https://codereview.chromium.org/2732983002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_session_manager.h (right):

https://codereview.chromium.org/2732983002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_session_manager.h:280: // On ARC session stopped
and/or data removal completion, this is called
Updated, just because I'm here.

[Yusuke Sato, 2017-03-06 22:11:49]

lgtm

https://codereview.chromium.org/2732983002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_session_manager.cc (right):

https://codereview.chromium.org/2732983002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_session_manager.cc:592: // Note: The callback
OnBackgroundAndroidManagementChecked() can be called
nit: 'StartBackgroundAndroidManagementCheck() may call
OnBackgroundAndroidManagementChecked() synchronously' (active voice) may be
simpler and clearer.

[hidehiko, 2017-03-07 05:10:00]

Thank you for review!

https://codereview.chromium.org/2732983002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_session_manager.cc (right):

https://codereview.chromium.org/2732983002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_session_manager.cc:592: // Note: The callback
OnBackgroundAndroidManagementChecked() can be called
On 2017/03/06 22:11:49, Yusuke Sato wrote:
> nit: 'StartBackgroundAndroidManagementCheck() may call
> OnBackgroundAndroidManagementChecked() synchronously' (active voice) may be
> simpler and clearer.

Done.

[hidehiko, 2017-03-07 05:10:04]

The CQ bit was checked by hidehiko@chromium.org

[hidehiko, 2017-03-07 05:10:04]

The patchset sent to the CQ was uploaded after l-g-t-m from yusukes@chromium.org
Link to the patchset: https://codereview.chromium.org/2732983002/#ps20001
(title: "Address comments.")

[commit-bot: I haz the power, 2017-03-07 05:11:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 05:15:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 05:15:14]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hidehiko, 2017-03-07 07:03:26]

The CQ bit was checked by hidehiko@chromium.org

[hidehiko, 2017-03-07 07:03:26]

The patchset sent to the CQ was uploaded after l-g-t-m from yusukes@chromium.org
Link to the patchset: https://codereview.chromium.org/2732983002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-07 07:04:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 09:30:07]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488870206175440,
"parent_rev": "0d01f9fe710dfbe680f317621a617e383422e14d", "commit_rev":
"20e3c142aad1cc086b840a647f0fce829299290e"}

[commit-bot: I haz the power, 2017-03-07 09:30:48]

Description was changed from

==========
Keep state even if AndroidManagement check returns MANAGED or ERROR.

This is the first CL to fix the state machine in ArcSessionManager.
With this CL, even if AndroidManagement check returns MANAGED or ERROR,
the state will be left as is (= CHECKING_ANDROID_MANAGEMENT),
expecting more action is done later.
On clicking RETRY button, the management check should re-run.
On giving up the check, Google Play Store enabled preference
should be set to false, which should trigger RequestDisable().

Along with the change, several refactoring is done.
- Renamed the function. (Removed "Arc" prefix, because it is
  ArcSessionManager's private method so redundant.)
- Extract StartBackgroundAndroidManagementCheck() method, to be
  consistent non-background method.

BUG=657687
BUG=b/31079732
TEST=Ran trybots.
==========

to

==========
Keep state even if AndroidManagement check returns MANAGED or ERROR.

This is the first CL to fix the state machine in ArcSessionManager.
With this CL, even if AndroidManagement check returns MANAGED or ERROR,
the state will be left as is (= CHECKING_ANDROID_MANAGEMENT),
expecting more action is done later.
On clicking RETRY button, the management check should re-run.
On giving up the check, Google Play Store enabled preference
should be set to false, which should trigger RequestDisable().

Along with the change, several refactoring is done.
- Renamed the function. (Removed "Arc" prefix, because it is
  ArcSessionManager's private method so redundant.)
- Extract StartBackgroundAndroidManagementCheck() method, to be
  consistent non-background method.

BUG=657687
BUG=b/31079732
TEST=Ran trybots.

Review-Url: https://codereview.chromium.org/2732983002
Cr-Commit-Position: refs/heads/master@{#455047}
Committed:
https://chromium.googlesource.com/chromium/src/+/20e3c142aad1cc086b840a647f0f...
==========

[commit-bot: I haz the power, 2017-03-07 09:30:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/20e3c142aad1cc086b840a647f0f...