Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2732973007: Forced ephemeral profile deletion on browser removal crash fix. (Closed)

Created:
3 years, 9 months ago by pastarmovj
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Forced ephemeral profile deletion on browser removal crash fix. Skiped all unnecessary activity actual to profile deletion from UI. All async activity is gone, and race on browser shutdown with it. BUG=691774 R=anthonyvd@chromium.org, bauerb@chromium.org Review-Url: https://codereview.chromium.org/2698683002 Cr-Commit-Position: refs/heads/master@{#454586} (cherry picked from commit 47cf44bdd2b1242e75a2bb5945a9412c41f4073d) Review-Url: https://codereview.chromium.org/2732973007 . Cr-Commit-Position: refs/branch-heads/3029@{#44} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/332d831ed5de659b31e94cec7a61f49a3d179e26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -7 lines) Patch
M chrome/browser/profiles/profile_manager.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 4 chunks +44 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 4 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
pastarmovj
3 years, 9 months ago (2017-03-07 16:38:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
332d831ed5de659b31e94cec7a61f49a3d179e26.

Powered by Google App Engine
This is Rietveld 408576698