Make SelectionController::setNonDirectionalSelectionIfNeeded() to take SelectionInFlatTree

Make SelectionController::setNonDirectionalSelectionIfNeeded() to take SelectionInFlatTree

This patch makes |SelectionController::setNonDirectionalSelectionIfNeeded()|
to |SelectionInFlatTree| for reducing |VisibleSelection| usage for improving
code health.

BUG=657237
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2732963002
Cr-Commit-Position: refs/heads/master@{#455688}
Committed: https://chromium.googlesource.com/chromium/src/+/86769268e85c0913ef8d86c46ff08baff599703e

[yosin_UTC9, 2017-03-06 09:48:02]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 09:48:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-06 09:50:04]

Description was changed from

==========
2017-03-06T18:46:44

2017-03-06T18:46:18

BUG=
==========

to

==========
Make SelectionController::setNonDirectionalSelectionIfNeeded() to take
SelectionInFlatTree

This patch makes |SelectionController::setNonDirectionalSelectionIfNeeded()|
to |SelectionInFlatTree| for reducing |VisibleSelection| usage for improving
code health.

BUG=657237
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-03-06 09:50:30]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-03-06 09:50:30]

PTAL

[commit-bot: I haz the power, 2017-03-06 11:14:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 11:14:49]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xiaocheng, 2017-03-06 19:04:32]

https://codereview.chromium.org/2732963002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/SelectionController.cpp (left):

https://codereview.chromium.org/2732963002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/SelectionController.cpp:399:
createVisibleSelection(builder.build()), selection().granularity(),
Guess this canonicalization is important and shouldn't be removed.

[yoichio, 2017-03-07 01:40:58]

Bot failures looks related to this change:
fast/forms/text/input-readonly-autoscroll.html
editing/selection/select-across-readonly-input-4.html
editing/selection/select-across-readonly-input-1.html

[yoichio, 2017-03-07 02:06:55]

On 2017/03/07 01:40:58, yoichio wrote:
> Bot failures looks related to this change:
> fast/forms/text/input-readonly-autoscroll.html
> editing/selection/select-across-readonly-input-4.html
> editing/selection/select-across-readonly-input-1.html
Please fix it before review.

[yosin_UTC9, 2017-03-07 04:12:48]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 04:13:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 07:05:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 07:05:32]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yosin_UTC9, 2017-03-09 05:32:32]

PTAL

Make VisibleSeleciton in setNonIDrecitonalSelectionIfNeeded(). :-<

[yoichio, 2017-03-09 05:49:14]

lgtm

[yosin_UTC9, 2017-03-09 05:59:44]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-03-09 06:00:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 07:21:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489039184471010,
"parent_rev": "4d77a388ceb8b2742c2ee4f0d2c8cc09a0aab4c6", "commit_rev":
"86769268e85c0913ef8d86c46ff08baff599703e"}

[commit-bot: I haz the power, 2017-03-09 07:23:24]

Description was changed from

==========
Make SelectionController::setNonDirectionalSelectionIfNeeded() to take
SelectionInFlatTree

This patch makes |SelectionController::setNonDirectionalSelectionIfNeeded()|
to |SelectionInFlatTree| for reducing |VisibleSelection| usage for improving
code health.

BUG=657237
TEST=n/a; no behavior changes
==========

to

==========
Make SelectionController::setNonDirectionalSelectionIfNeeded() to take
SelectionInFlatTree

This patch makes |SelectionController::setNonDirectionalSelectionIfNeeded()|
to |SelectionInFlatTree| for reducing |VisibleSelection| usage for improving
code health.

BUG=657237
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2732963002
Cr-Commit-Position: refs/heads/master@{#455688}
Committed:
https://chromium.googlesource.com/chromium/src/+/86769268e85c0913ef8d86c46ff0...
==========

[commit-bot: I haz the power, 2017-03-09 07:23:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/86769268e85c0913ef8d86c46ff0...