Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 273293002: Clean up unnecessary PassRefPtr.h include in modules (Closed)

Created:
6 years, 7 months ago by gyuyoung-inactive
Modified:
6 years, 7 months ago
Reviewers:
haraken, eseidel
CC:
blink-reviews, timvolodine, nhiroki, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com, kinuko, mvanouwerkerk+watch_chromium.org, tzik, Inactive, gyuyoung.kim_webkit.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Clean up unnecessary PassRefPtr.h include in modules As oilpan is applied, PassRefPtr has been converted to PassRefPtrWillBeRawPtr which is defined in Handle.h. So, many files don't need to include PassRefPtr.h anymore. This cl cleans up it in some modules. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173822

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -36 lines) Patch
M Source/modules/crypto/AesKeyAlgorithm.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/crypto/Key.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/crypto/KeyAlgorithm.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/crypto/SubtleCrypto.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceMotionData.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceOrientationData.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/DOMFilePath.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/DOMFileSystemBase.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/DOMWindowFileSystem.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/DataTransferItemFileSystem.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/DirectoryEntry.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/DirectoryEntrySync.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/DirectoryReader.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/DirectoryReaderBase.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/DirectoryReaderSync.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/Entry.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/EntryBase.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/EntrySync.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/FileEntrySync.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/FileSystemCallbacks.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/FileWriter.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/FileWriterSync.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/HTMLInputElementFileSystem.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/InspectorFrontendHostFileSystem.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/WorkerGlobalScopeFileSystem.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/gamepad/GamepadList.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/gamepad/WebKitGamepadList.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/geolocation/GeolocationError.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/geolocation/GeolocationPosition.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/geolocation/PositionError.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/geolocation/PositionOptions.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/geolocation/testing/GeolocationClientMock.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtils.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/notifications/Notification.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/notifications/NotificationClient.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
gyuyoung-inactive
6 years, 7 months ago (2014-05-10 06:55:58 UTC) #1
eseidel
lgtm
6 years, 7 months ago (2014-05-10 07:23:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/273293002/30001
6 years, 7 months ago (2014-05-10 07:24:12 UTC) #3
eseidel
I guess PassRefPtr is going away in OilPan land anyway.
6 years, 7 months ago (2014-05-10 07:24:25 UTC) #4
gyuyoung-inactive
On 2014/05/10 07:24:25, eseidel wrote: > I guess PassRefPtr is going away in OilPan land ...
6 years, 7 months ago (2014-05-10 07:27:23 UTC) #5
commit-bot: I haz the power
Change committed as 173822
6 years, 7 months ago (2014-05-10 08:52:35 UTC) #6
sof
6 years, 7 months ago (2014-05-10 20:53:47 UTC) #7
Message was sent while issue was closed.
For modules/ subdirs that have switched over to Oilpan types (and not transition
types like PassRefPtrWillBeRawPtr<>), it makes sense to tidy this up; good
change.

For those that haven't, it's perhaps worth waiting until they do? Should Oilpan
end up not being used, it will just make reverting just a tad more cumbersome.

Powered by Google App Engine
This is Rietveld 408576698