Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2732913006: Remove unnecessary iOS ifdefs in NSS files. (Closed)

Created:
3 years, 9 months ago by davidben
Modified:
3 years, 9 months ago
Reviewers:
svaldez
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary iOS ifdefs in NSS files. NSS is no longer used on iOS. BUG=591544 Review-Url: https://codereview.chromium.org/2732913006 Cr-Commit-Position: refs/heads/master@{#455083} Committed: https://chromium.googlesource.com/chromium/src/+/4c99028ada1ad4080a09519f18aef2c9de29de31

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M net/cert/test_root_certs.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/cert/test_root_certs_nss.cc View 4 chunks +0 lines, -11 lines 0 comments Download
M net/cert/x509_util_nss.h View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
davidben
3 years, 9 months ago (2017-03-06 22:18:33 UTC) #4
svaldez
lgtm Attach to the bug.
3 years, 9 months ago (2017-03-06 22:20:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732913006/20001
3 years, 9 months ago (2017-03-06 22:21:53 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/395070)
3 years, 9 months ago (2017-03-07 00:47:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732913006/20001
3 years, 9 months ago (2017-03-07 14:54:35 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 16:00:11 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4c99028ada1ad4080a09519f18ae...

Powered by Google App Engine
This is Rietveld 408576698