Post fix of CL "declare a variable before using it"

Post fix of CL "declare a variable before using it"

PVS-Studio pointed out that an uninitialized variable 'limit' is used to 
initialize itself, which may cause undefined behavior. Other calls to 
StringToSizeT() don't have this issue.

After my landing crrev.com/2724153004 for the fix, the declaration and 
assignment of variable |limit| are separate. If somebody adds code 
between them, there will be a non-trivial interval of |limit| having an 
undefined value. 

This CL fixed this by initializing |limit| right after its declaration.

BUG=697659
Review-Url: https://codereview.chromium.org/2732913004
Cr-Commit-Position: refs/heads/master@{#454950}
Committed: https://chromium.googlesource.com/chromium/src/+/ed17a3d795edc5af91cd6074a7c299425b1fe9d7

[chengx, 2017-03-06 18:47:03]

The CQ bit was checked by chengx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 18:47:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chengx, 2017-03-06 18:51:42]

Description was changed from

==========
Initialize limit to SIZE_MAX.

BUG=697659
==========

to

==========
Post fix of CL "declare a variable before using it"

PVS-Studio pointed out that an uninitialized variable 'limit' is used to 
initialize itself, which may cause undefined behavior. Other calls to 
StringToSizeT() don't have this issue.

After landing crrev.com/2724153004 for the fix, the declaration and 
assignment of variable |limit| are separate, and if somebody adds code 
between them, there will be a non-trivial interval of |limit| having an 
undefined value. 

This CL fixed this by initializing |limit| right after its declaration.

BUG=697659
==========

[chengx, 2017-03-06 18:52:36]

Description was changed from

==========
Post fix of CL "declare a variable before using it"

PVS-Studio pointed out that an uninitialized variable 'limit' is used to 
initialize itself, which may cause undefined behavior. Other calls to 
StringToSizeT() don't have this issue.

After landing crrev.com/2724153004 for the fix, the declaration and 
assignment of variable |limit| are separate, and if somebody adds code 
between them, there will be a non-trivial interval of |limit| having an 
undefined value. 

This CL fixed this by initializing |limit| right after its declaration.

BUG=697659
==========

to

==========
Post fix of CL "declare a variable before using it"

PVS-Studio pointed out that an uninitialized variable 'limit' is used to 
initialize itself, which may cause undefined behavior. Other calls to 
StringToSizeT() don't have this issue.

After landing crrev.com/2724153004 for the fix, the declaration and 
assignment of variable |limit| are separate. If somebody adds code 
between them, there will be a non-trivial interval of |limit| having an 
undefined value. 

This CL fixed this by initializing |limit| right after its declaration.

BUG=697659
==========

[chengx, 2017-03-06 18:55:20]

Description was changed from

==========
Post fix of CL "declare a variable before using it"

PVS-Studio pointed out that an uninitialized variable 'limit' is used to 
initialize itself, which may cause undefined behavior. Other calls to 
StringToSizeT() don't have this issue.

After landing crrev.com/2724153004 for the fix, the declaration and 
assignment of variable |limit| are separate. If somebody adds code 
between them, there will be a non-trivial interval of |limit| having an 
undefined value. 

This CL fixed this by initializing |limit| right after its declaration.

BUG=697659
==========

to

==========
Post fix of CL "declare a variable before using it"

PVS-Studio pointed out that an uninitialized variable 'limit' is used to 
initialize itself, which may cause undefined behavior. Other calls to 
StringToSizeT() don't have this issue.

After my landing crrev.com/2724153004 for the fix, the declaration and 
assignment of variable |limit| are separate. If somebody adds code 
between them, there will be a non-trivial interval of |limit| having an 
undefined value. 

This CL fixed this by initializing |limit| right after its declaration.

BUG=697659
==========

[chengx, 2017-03-06 19:47:50]

chengx@chromium.org changed reviewers:
+ vabr@chromium.org

[chengx, 2017-03-06 19:47:51]

Hi vabr@, this is the post fix the my previous CL crrev.com/2724153004. PTAL~

Also, if you think this post fix is fine, could you please also give me a LGTM
for my previous CL? I guess it is your "not LGTM" that marked your status "red"
for that CL while it is green for reviewers who give LGTM. The red color
indicates it is a problematic CL I suppose.

[vabr (Chromium), 2017-03-06 19:50:38]

On 2017/03/06 19:47:51, chengx wrote:
> Hi vabr@, this is the post fix the my previous CL crrev.com/2724153004. PTAL~
> 
> Also, if you think this post fix is fine, could you please also give me a LGTM
> for my previous CL? I guess it is your "not LGTM" that marked your status
"red"
> for that CL while it is green for reviewers who give LGTM. The red color
> indicates it is a problematic CL I suppose.

LGTM, thanks for the quick fix!
Vaclav

[commit-bot: I haz the power, 2017-03-06 20:36:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 20:36:23]

Dry run: This issue passed the CQ dry run.

[chengx, 2017-03-06 20:43:42]

The CQ bit was checked by chengx@chromium.org

[commit-bot: I haz the power, 2017-03-06 20:44:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 20:49:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488833022153040, "parent_rev":
"4a6080201a29001f398861f94f8a473d646facd2", "commit_rev":
"ed17a3d795edc5af91cd6074a7c299425b1fe9d7"}

[commit-bot: I haz the power, 2017-03-06 20:50:24]

Description was changed from

==========
Post fix of CL "declare a variable before using it"

PVS-Studio pointed out that an uninitialized variable 'limit' is used to 
initialize itself, which may cause undefined behavior. Other calls to 
StringToSizeT() don't have this issue.

After my landing crrev.com/2724153004 for the fix, the declaration and 
assignment of variable |limit| are separate. If somebody adds code 
between them, there will be a non-trivial interval of |limit| having an 
undefined value. 

This CL fixed this by initializing |limit| right after its declaration.

BUG=697659
==========

to

==========
Post fix of CL "declare a variable before using it"

PVS-Studio pointed out that an uninitialized variable 'limit' is used to 
initialize itself, which may cause undefined behavior. Other calls to 
StringToSizeT() don't have this issue.

After my landing crrev.com/2724153004 for the fix, the declaration and 
assignment of variable |limit| are separate. If somebody adds code 
between them, there will be a non-trivial interval of |limit| having an 
undefined value. 

This CL fixed this by initializing |limit| right after its declaration.

BUG=697659

Review-Url: https://codereview.chromium.org/2732913004
Cr-Commit-Position: refs/heads/master@{#454950}
Committed:
https://chromium.googlesource.com/chromium/src/+/ed17a3d795edc5af91cd6074a7c2...
==========

[commit-bot: I haz the power, 2017-03-06 20:50:25]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ed17a3d795edc5af91cd6074a7c2...