Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Issue 2732883007: tsan: Add suppression for a net unittest (Closed)

Created:
3 years, 9 months ago by Michael Achenbach
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 16 (9 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/2732883007/diff/1/build/sanitizers/tsan_suppressions.cc File build/sanitizers/tsan_suppressions.cc (right): https://codereview.chromium.org/2732883007/diff/1/build/sanitizers/tsan_suppressions.cc#newcode274 build/sanitizers/tsan_suppressions.cc:274: "race:net::(anonymous namespace)::ProxyResolverV8TracingImpl::RequestImpl" Tried to go with net::(anonymous namespace)::ProxyResolverV8TracingTest_CancelWhileBlockedInNonBlockingDns2_Test ...
3 years, 9 months ago (2017-03-08 14:39:19 UTC) #4
Michael Achenbach
PTAL
3 years, 9 months ago (2017-03-08 14:39:21 UTC) #5
jochen (gone - plz use gerrit)
suppressions should be mostly for false positives, not to avoid fixing an issue. Why is ...
3 years, 9 months ago (2017-03-08 14:43:24 UTC) #6
jochen (gone - plz use gerrit)
lgtm
3 years, 9 months ago (2017-03-08 15:25:04 UTC) #9
Michael Achenbach
On 2017/03/08 15:25:04, jochen wrote: > lgtm Thanks.
3 years, 9 months ago (2017-03-08 15:33:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732883007/1
3 years, 9 months ago (2017-03-08 15:34:01 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 15:38:23 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ecaade2ce813c97d168576d035f8...

Powered by Google App Engine
This is Rietveld 408576698