Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1491)

Issue 2732883004: [profiler] Web UI - add time-as-text description to the interval highlight. (Closed)

Created:
3 years, 9 months ago by Jarin
Modified:
3 years, 9 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[profiler] Web UI - add time-as-text description to the interval highlight. Review-Url: https://codereview.chromium.org/2732883004 Cr-Commit-Position: refs/heads/master@{#43639} Committed: https://chromium.googlesource.com/v8/v8/+/698c2f3bbdfc3b90b3e15878421e820c1e26b398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -11 lines) Patch
M tools/profview/profview.js View 5 chunks +69 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Jarin
Could you take a look, please?
3 years, 9 months ago (2017-03-06 16:08:56 UTC) #2
Camillo Bruni
lgtm
3 years, 9 months ago (2017-03-06 18:41:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732883004/1
3 years, 9 months ago (2017-03-07 13:04:28 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 13:29:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/698c2f3bbdfc3b90b3e15878421e820c1e2...

Powered by Google App Engine
This is Rietveld 408576698