Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2732863004: Add VisibleUnits::startOfWordPosition (Closed)

Created:
3 years, 9 months ago by yoichio
Modified:
3 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add VisibleUnits::startOfWordPosition This is Position version of |startOfWord| which returns VisiblePosition. Since returned Position should be already canonicalized with |previousBoundary()|, we can replace them. This is preparation for letting |startOfWord| and |endOfWord| return uncanonicalized Position. BUG=657237, 697725 TEST=No change in behavior. Review-Url: https://codereview.chromium.org/2732863004 Cr-Commit-Position: refs/heads/master@{#455146} Committed: https://chromium.googlesource.com/chromium/src/+/f47de6fa1c432e87dc270ff96b1089e5983c2cf1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.h View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 2 chunks +18 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
yoichio
3 years, 9 months ago (2017-03-07 02:15:09 UTC) #5
yosin_UTC9
lgtm
3 years, 9 months ago (2017-03-07 02:20:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732863004/1
3 years, 9 months ago (2017-03-07 07:58:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/379376)
3 years, 9 months ago (2017-03-07 09:42:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732863004/1
3 years, 9 months ago (2017-03-07 14:13:30 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 18:29:18 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f47de6fa1c432e87dc270ff96b10...

Powered by Google App Engine
This is Rietveld 408576698