Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2732863003:
MD Settings: Make heading focusable in side nav. (Closed)
|
Created:
3 years, 9 months ago by hcarmona Modified:
3 years, 9 months ago Reviewers:
Dan Beam CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: Make heading focusable in side nav.
R=dbeam@chromium.org
BUG=697343
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2732863003
Cr-Commit-Position: refs/heads/master@{#454968}
Committed: https://chromium.googlesource.com/chromium/src/+/efccf6c05043bf2ac89f090f5017e5b1bb82dd8d
Patch Set 1 #
Total comments: 1
Messages
Total messages: 16 (9 generated)
Description was changed from ========== MD Settings: Make heading focusable in side nav. R=dbeam@chromium.org BUG=ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js ========== to ========== MD Settings: Make heading focusable in side nav. R=dbeam@chromium.org BUG=ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
PTAL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
hey Hector, did you mean to paste something else into BUG=?
Description was changed from ========== MD Settings: Make heading focusable in side nav. R=dbeam@chromium.org BUG=ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Make heading focusable in side nav. R=dbeam@chromium.org BUG=697343 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
On 2017/03/06 20:15:26, Dan Beam wrote: > hey Hector, did you mean to paste something else into BUG=? Yes, sorry about that. Fixed now
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm yeah, this basically the same thing that i did for cr-dialog
nothing to change, still lgtm, just for clarification (hopefully) https://codereview.chromium.org/2732863003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_ui/settings_ui.html (right): https://codereview.chromium.org/2732863003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_ui/settings_ui.html:88: <div class="drawer-header" tabindex="-1">$i18n{settings}</div> the difference is that .drawer-header actually live outside of <dialog is="cr-drawer"> and there's a <content> slot. what i did was change the *inside* of cr-dialog does that make sense?
The CQ bit was checked by hcarmona@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1488836154016730, "parent_rev":
"1652d291e9cebc86b0b671c0d08b2a5964780da6", "commit_rev":
"efccf6c05043bf2ac89f090f5017e5b1bb82dd8d"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Make heading focusable in side nav. R=dbeam@chromium.org BUG=697343 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Make heading focusable in side nav. R=dbeam@chromium.org BUG=697343 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2732863003 Cr-Commit-Position: refs/heads/master@{#454968} Committed: https://chromium.googlesource.com/chromium/src/+/efccf6c05043bf2ac89f090f5017... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/efccf6c05043bf2ac89f090f5017... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
