Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2732863002:
Propagate active document URL to result of DOMParser.parseFromString() (Closed)
|
Created:
3 years, 9 months ago by MartinRogalla Modified:
3 years, 9 months ago Reviewers:
tkent CC:
blink-reviews, chromium-reviews, dominicc+watchlist_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPropagate active document URL to result of DOMParser.parseFromString()
This patch ensures that the URL of the active document is propagated to the
result of a DOMParser.parseFromString() as is specified in [1]. The changes
ensure that the w3c-test in [2] passes.
[1] - https://www.w3.org/TR/2016/WD-DOM-Parsing-20160517/#widl-DOMParser-parseFromString-Document-DOMString-str-SupportedType-type
[2] - http://w3c-test.org/domparsing/DOMParser-parseFromString-html.html
BUG=698128
Review-Url: https://codereview.chromium.org/2732863002
Cr-Commit-Position: refs/heads/master@{#455343}
Committed: https://chromium.googlesource.com/chromium/src/+/c87999ea945e86d70cc5f98df81d65efc567cdd5
Patch Set 1 #Patch Set 2 : Applied fix, removed test expectations. (all tests pass) #Patch Set 3 : Fixed test expectations. #
Messages
Total messages: 36 (22 generated)
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
I believe this fixes the issue. Thank you for your patience.
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by tkent@chromium.org
The CQ bit was checked by tkent@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Is this still waiting on an action from me?
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/03/07 at 15:28:38, martin wrote: > Is this still waiting on an action from me? No. Bots are trying to land this patch.
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488919953548890,
"parent_rev": "2c885e024b61f6f0bf1cb7b5624b2b202917c0de", "commit_rev":
"c87999ea945e86d70cc5f98df81d65efc567cdd5"}
Message was sent while issue was closed.
Description was changed from ========== Propagate active document URL to result of DOMParser.parseFromString() This patch ensures that the URL of the active document is propagated to the result of a DOMParser.parseFromString() as is specified in [1]. The changes ensure that the w3c-test in [2] passes. [1] - https://www.w3.org/TR/2016/WD-DOM-Parsing-20160517/#widl-DOMParser-parseFromS... [2] - http://w3c-test.org/domparsing/DOMParser-parseFromString-html.html BUG=698128 ========== to ========== Propagate active document URL to result of DOMParser.parseFromString() This patch ensures that the URL of the active document is propagated to the result of a DOMParser.parseFromString() as is specified in [1]. The changes ensure that the w3c-test in [2] passes. [1] - https://www.w3.org/TR/2016/WD-DOM-Parsing-20160517/#widl-DOMParser-parseFromS... [2] - http://w3c-test.org/domparsing/DOMParser-parseFromString-html.html BUG=698128 Review-Url: https://codereview.chromium.org/2732863002 Cr-Commit-Position: refs/heads/master@{#455343} Committed: https://chromium.googlesource.com/chromium/src/+/c87999ea945e86d70cc5f98df81d... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/c87999ea945e86d70cc5f98df81d... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
