[preload] Split up media into video, audio and track

[preload] Split up media into video, audio and track

Align implementation with spec change https://github.com/whatwg/fetch/pull/437

PSA at https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BN6tqGLBmuI

BUG=698521
Review-Url: https://codereview.chromium.org/2732853003
Cr-Commit-Position: refs/heads/master@{#455723}
Committed: https://chromium.googlesource.com/chromium/src/+/543995a7a4c88dd03ba1e669193f0ce4796b7964

[Yoav Weiss, 2017-03-06 08:13:15]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 08:13:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoav Weiss, 2017-03-06 08:30:08]

Description was changed from

==========
[preload] Split up media into video, audio and track

BUG=
==========

to

==========
[preload] Split up media into video, audio and track

Align implementation with spec change https://github.com/whatwg/fetch/pull/437

BUG=698521
==========

[Yoav Weiss, 2017-03-06 08:30:09]

yoav@yoav.ws changed reviewers:
+ csharrison@chromium.org

[commit-bot: I haz the power, 2017-03-06 09:08:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 09:08:30]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Charlie Harrison, 2017-03-06 15:16:11]

Do we show an error for incorrect as= names? If so, adding a test for media
would be nice.

[Yoav Weiss, 2017-03-06 16:46:16]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 16:46:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoav Weiss, 2017-03-06 16:54:51]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 16:54:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoav Weiss, 2017-03-06 16:55:09]

On 2017/03/06 15:16:11, Charlie Harrison wrote:
> Do we show an error for incorrect as= names? If so, adding a test for media
> would be nice.

Good point! Added one.

In ter

[Yoav Weiss, 2017-03-06 16:56:13]

Since this is a Web exposed change, I'm thinking of sending out a PSA (I don't
think an intent is necessary here). Let me know if you think otherwise.

[Charlie Harrison, 2017-03-06 17:52:39]

You're better equipped to answer that then me. How many sites with start failing
preloads on existing as="media" rules?

[commit-bot: I haz the power, 2017-03-06 19:18:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 19:18:44]

Dry run: This issue passed the CQ dry run.

[Yoav Weiss, 2017-03-06 19:55:55]

On 2017/03/06 17:52:39, Charlie Harrison wrote:
> You're better equipped to answer that then me. How many sites with start
failing
> preloads on existing as="media" rules?

I'd guess very few actually preload with "media" right now, but we don't have
usecounter data on that.

[Charlie Harrison, 2017-03-06 19:57:54]

OK LGTM to land conditional on sending a PSA to blink-dev.

[Yoav Weiss, 2017-03-09 10:17:41]

Description was changed from

==========
[preload] Split up media into video, audio and track

Align implementation with spec change https://github.com/whatwg/fetch/pull/437

BUG=698521
==========

to

==========
[preload] Split up media into video, audio and track

Align implementation with spec change https://github.com/whatwg/fetch/pull/437

PSA at
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BN6tqGLBmuI

BUG=698521
==========

[Yoav Weiss, 2017-03-09 10:18:33]

On 2017/03/06 19:57:54, Charlie Harrison wrote:
> OK LGTM to land conditional on sending a PSA to blink-dev.

Thanks! PSA sent 2 days ago at
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BN6tqGLBmuI
with no objections.

[Yoav Weiss, 2017-03-09 10:18:39]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2017-03-09 10:19:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 13:13:11]

CQ is committing da patch.

Bot data: {"patchset_id": 10009, "attempt_start_ts": 1489054719699440,
"parent_rev": "0e3dd8a2fa4956c145952fccdbf33383984419c2", "commit_rev":
"543995a7a4c88dd03ba1e669193f0ce4796b7964"}

[commit-bot: I haz the power, 2017-03-09 13:13:48]

Description was changed from

==========
[preload] Split up media into video, audio and track

Align implementation with spec change https://github.com/whatwg/fetch/pull/437

PSA at
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BN6tqGLBmuI

BUG=698521
==========

to

==========
[preload] Split up media into video, audio and track

Align implementation with spec change https://github.com/whatwg/fetch/pull/437

PSA at
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BN6tqGLBmuI

BUG=698521

Review-Url: https://codereview.chromium.org/2732853003
Cr-Commit-Position: refs/heads/master@{#455723}
Committed:
https://chromium.googlesource.com/chromium/src/+/543995a7a4c88dd03ba1e669193f...
==========

[commit-bot: I haz the power, 2017-03-09 13:13:49]

Committed patchset #3 (id:10009) as
https://chromium.googlesource.com/chromium/src/+/543995a7a4c88dd03ba1e669193f...

[droger, 2017-03-23 12:47:25]

droger@chromium.org changed reviewers:
+ droger@chromium.org

[droger, 2017-03-23 12:47:26]

https://codereview.chromium.org/2732853003/diff/10009/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/LinkLoader.cpp (right):

https://codereview.chromium.org/2732853003/diff/10009/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkLoader.cpp:201: } else if (as ==
"track") {
drive-by: this code is duplicated on line 205 below.

[Yoav Weiss, 2017-03-23 13:57:54]

https://codereview.chromium.org/2732853003/diff/10009/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/LinkLoader.cpp (right):

https://codereview.chromium.org/2732853003/diff/10009/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/LinkLoader.cpp:201: } else if (as ==
"track") {
On 2017/03/23 12:47:26, droger wrote:
> drive-by: this code is duplicated on line 205 below.

oops!