[typedarrays] Move %TypedArray%.prototype.includes to C++ builtins

[typedarrays] Move %TypedArray%.prototype.includes to C++ builtins

- Remove TypedArrayIncludes in src/js/typedarray.js
- Implement it to C++ using the IncludesValue implementation
  in ElementsAccessor

BUG=v8:5929
Review-Url: https://codereview.chromium.org/2732823002
Cr-Commit-Position: refs/heads/master@{#43625}
Committed: https://chromium.googlesource.com/v8/v8/+/a9ace2989326eb51b2b1f4b9ab1185b050845944

[Choongwoo Han, 2017-03-05 07:16:25]

Description was changed from

==========
[typedarrays] Move %TypedArray%.prototype.includes to C++ builtins

- Remove TypedArrayIncludes in src/js/typedarray.js
- Implement it to C++ using the IncludesValue implementation
  in ElementsAccessor

BUG=v8:5929
==========

to

==========
[typedarrays] Move %TypedArray%.prototype.includes to C++ builtins

- Remove TypedArrayIncludes in src/js/typedarray.js
- Implement it to C++ using the IncludesValue implementation
  in ElementsAccessor

BUG=v8:5929
==========

[Choongwoo Han, 2017-03-05 07:16:25]

cwhan.tunz@gmail.com changed reviewers:
+ bmeurer@chromium.org, caitp@chromium.org, littledan@chromium.org

[Choongwoo Han, 2017-03-05 07:16:58]

PTAL

[Benedikt Meurer, 2017-03-05 17:47:35]

LGTM from me. Thank you!

I suspect really specializing the IncludesValue in the ElementsAccessor to the
ctype and not just always comparing by double value could speed it up further
for integral typed arrays, but that's an independent optimization.

[Choongwoo Han, 2017-03-06 22:06:36]

The CQ bit was checked by cwhan.tunz@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 22:06:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 22:34:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 22:34:43]

Dry run: This issue passed the CQ dry run.

[Choongwoo Han, 2017-03-07 05:04:47]

The CQ bit was checked by cwhan.tunz@gmail.com

[commit-bot: I haz the power, 2017-03-07 05:04:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 05:06:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488863087430640, "parent_rev":
"4951ff887c1b8e79ca723e57df9d9507778f8a40", "commit_rev":
"a9ace2989326eb51b2b1f4b9ab1185b050845944"}

[commit-bot: I haz the power, 2017-03-07 05:06:35]

Description was changed from

==========
[typedarrays] Move %TypedArray%.prototype.includes to C++ builtins

- Remove TypedArrayIncludes in src/js/typedarray.js
- Implement it to C++ using the IncludesValue implementation
  in ElementsAccessor

BUG=v8:5929
==========

to

==========
[typedarrays] Move %TypedArray%.prototype.includes to C++ builtins

- Remove TypedArrayIncludes in src/js/typedarray.js
- Implement it to C++ using the IncludesValue implementation
  in ElementsAccessor

BUG=v8:5929

Review-Url: https://codereview.chromium.org/2732823002
Cr-Commit-Position: refs/heads/master@{#43625}
Committed:
https://chromium.googlesource.com/v8/v8/+/a9ace2989326eb51b2b1f4b9ab1185b0508...
==========

[commit-bot: I haz the power, 2017-03-07 05:06:36]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a9ace2989326eb51b2b1f4b9ab1185b0508...