Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2732803002: Drop UniqueId from include/v8.h (Closed)

Created:
3 years, 9 months ago by Anna Henningsen
Modified:
3 years, 9 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Drop UniqueId from include/v8.h It's unused since March 2 2017 (https://chromium-review.googlesource.com/448539). This removes it assuming that leaving it in the header was an oversight. BUG=v8:5828 Review-Url: https://codereview.chromium.org/2732803002 Cr-Commit-Position: refs/heads/master@{#43605} Committed: https://chromium.googlesource.com/v8/v8/+/de1461b7efd2f52adc9b544240a04937c510a91c

Patch Set 1 #

Patch Set 2 : Drop UniqueId from include/v8.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M include/v8.h View 1 chunk +0 lines, -24 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-api-interceptors.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-global-handles.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Anna Henningsen
3 years, 9 months ago (2017-03-05 00:37:40 UTC) #2
Michael Lippautz
LGTM, thanks! Please add "BUG=v8:5828" to the description as this should've been removed as part ...
3 years, 9 months ago (2017-03-06 09:42:42 UTC) #3
Anna Henningsen
On 2017/03/06 09:42:42, Michael Lippautz wrote: > Please add "BUG=v8:5828" to the description as this ...
3 years, 9 months ago (2017-03-06 10:15:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732803002/20001
3 years, 9 months ago (2017-03-06 10:31:09 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 10:58:07 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/de1461b7efd2f52adc9b544240a04937c51...

Powered by Google App Engine
This is Rietveld 408576698