Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2732773002: Create a Lite Page bit for previews and fallback to Lo-Fi (Closed)

Created:
3 years, 9 months ago by megjablon
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Create a Lite Page bit for previews and fallback to Lo-Fi If a lite-page is requested and the server does not provide one, Chrome should request a Lo-Fi image on subresources. However, Chrome should not request empty-image on the subresource requests of a Weblite page. BUG=660212 Review-Url: https://codereview.chromium.org/2642793005 Cr-Commit-Position: refs/heads/master@{#454638} (cherry picked from commit 3f4bae9092c2ac1443f2c26867b7fad7f10df1ca) Review-Url: https://codereview.chromium.org/2732773002 . Cr-Commit-Position: refs/branch-heads/3029@{#6} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/e1725ef3c99b3ea313fe81b855a7d0568e540d38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+338 lines, -125 lines) Patch
M chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M components/data_reduction_proxy/content/browser/content_lofi_decider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/content/browser/content_lofi_decider.cc View 6 chunks +34 lines, -19 lines 0 comments Download
M components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc View 12 chunks +133 lines, -49 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h View 2 chunks +19 lines, -8 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc View 4 chunks +43 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h View 1 chunk +7 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc View 1 chunk +12 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc View 10 chunks +16 lines, -16 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params.h View 3 chunks +10 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/common/lofi_decider.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/previews_state.h View 2 chunks +16 lines, -4 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +11 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebURLRequest.h View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
megjablon
3 years, 9 months ago (2017-03-04 01:04:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e1725ef3c99b3ea313fe81b855a7d0568e540d38.

Powered by Google App Engine
This is Rietveld 408576698