AIX: Work around for malloc(0) behavior

AIX: Work around for malloc(0) behavior

malloc(0) returning 0 is expected behavior on AIX but
compiling with -D_LINUX_SOURCE_COMPAT, malloc(0) should
return a valid pointer (which we do define for AIX). However,
including cstdlib resets the behaviour of _LINUX_SOURCE_COMPAT.
GCC bug: 79839

R=jochen@chromium.org, titzer@chromium.org
BUG=
LOG=N

Review-Url: https://codereview.chromium.org/2732743002
Cr-Commit-Position: refs/heads/master@{#43647}
Committed: https://chromium.googlesource.com/v8/v8/+/7c0f3f0623aa6823caf0cf006dc5cc18148a4bd4

[JaideepBajwa, 2017-03-03 21:11:54]

ptal

[titzer, 2017-03-04 23:29:56]

https://codereview.chromium.org/2732743002/diff/1/test/cctest/wasm/wasm-run-u...
File test/cctest/wasm/wasm-run-utils.h (right):

https://codereview.chromium.org/2732743002/diff/1/test/cctest/wasm/wasm-run-u...
test/cctest/wasm/wasm-run-utils.h:114: #if V8_OS_AIX && _LINUX_SOURCE_COMPAT
What about changing the CHECK() below to be CHECK(size || instance->mem_start)?
Or use a fancy CHECK_IMPLIES()..

[JaideepBajwa, 2017-03-05 05:11:03]

https://codereview.chromium.org/2732743002/diff/1/test/cctest/wasm/wasm-run-u...
File test/cctest/wasm/wasm-run-utils.h (right):

https://codereview.chromium.org/2732743002/diff/1/test/cctest/wasm/wasm-run-u...
test/cctest/wasm/wasm-run-utils.h:114: #if V8_OS_AIX && _LINUX_SOURCE_COMPAT
On 2017/03/04 23:29:56, titzer wrote:
> What about changing the CHECK() below to be CHECK(size ||
instance->mem_start)?
> Or use a fancy CHECK_IMPLIES()..
> 
should the CHECK() be: CHECK(size == 0 || instance->mem_start)? because size and
instance->mem_start would both be 0 on aix and it would fail.

[JaideepBajwa, 2017-03-06 22:35:26]

https://codereview.chromium.org/2732743002/diff/1/test/cctest/wasm/wasm-run-u...
File test/cctest/wasm/wasm-run-utils.h (right):

https://codereview.chromium.org/2732743002/diff/1/test/cctest/wasm/wasm-run-u...
test/cctest/wasm/wasm-run-utils.h:114: #if V8_OS_AIX && _LINUX_SOURCE_COMPAT
On 2017/03/04 23:29:56, titzer wrote:
> What about changing the CHECK() below to be CHECK(size ||
instance->mem_start)?
> Or use a fancy CHECK_IMPLIES()..
> 

Done.

[titzer, 2017-03-07 09:33:58]

lgtm

[jochen (gone - plz use gerrit), 2017-03-07 11:45:41]

lgtm

[JaideepBajwa, 2017-03-07 14:18:42]

The CQ bit was checked by bjaideep@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 14:18:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 14:45:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 14:45:22]

Dry run: This issue passed the CQ dry run.

[JaideepBajwa, 2017-03-07 15:45:58]

The CQ bit was checked by bjaideep@ca.ibm.com

[commit-bot: I haz the power, 2017-03-07 15:46:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 15:49:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488901558927220,
"parent_rev": "58ff145ef0aa4dd472e6eade4ad395a786c3a221", "commit_rev":
"7c0f3f0623aa6823caf0cf006dc5cc18148a4bd4"}

[commit-bot: I haz the power, 2017-03-07 15:49:26]

Description was changed from

==========
AIX: Work around for malloc(0) behavior

malloc(0) returning 0 is expected behavior on AIX but
compiling with -D_LINUX_SOURCE_COMPAT, malloc(0) should
return a valid pointer (which we do define for AIX). However,
including cstdlib resets the behaviour of _LINUX_SOURCE_COMPAT.
GCC bug: 79839

R=jochen@chromium.org, titzer@chromium.org
BUG=
LOG=N
==========

to

==========
AIX: Work around for malloc(0) behavior

malloc(0) returning 0 is expected behavior on AIX but
compiling with -D_LINUX_SOURCE_COMPAT, malloc(0) should
return a valid pointer (which we do define for AIX). However,
including cstdlib resets the behaviour of _LINUX_SOURCE_COMPAT.
GCC bug: 79839

R=jochen@chromium.org, titzer@chromium.org
BUG=
LOG=N

Review-Url: https://codereview.chromium.org/2732743002
Cr-Commit-Position: refs/heads/master@{#43647}
Committed:
https://chromium.googlesource.com/v8/v8/+/7c0f3f0623aa6823caf0cf006dc5cc18148...
==========

[commit-bot: I haz the power, 2017-03-07 15:49:27]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/7c0f3f0623aa6823caf0cf006dc5cc18148...