Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2732663002: Late creation of CodegenEnqueuer (Closed)

Created:
3 years, 9 months ago by Johnni Winther
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Late creation of CodegenEnqueuer This is part of a general move towards creating codegen-specific object at codegen start instead of at resolution start. Many of the don't even make sense before, for instance, ClosedWorld has been computed. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/c7011e2d825a7cc1fb22cc2fe7c50b8601909832

Patch Set 1 #

Patch Set 2 : Remove eager creation #

Total comments: 2

Patch Set 3 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -45 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 9 chunks +27 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 3 chunks +5 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/interceptor_data.dart View 1 2 3 chunks +17 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/type_representation_test.dart View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 9 months ago (2017-03-03 13:48:30 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2732663002/diff/20001/pkg/compiler/lib/src/js_backend/interceptor_data.dart File pkg/compiler/lib/src/js_backend/interceptor_data.dart (right): https://codereview.chromium.org/2732663002/diff/20001/pkg/compiler/lib/src/js_backend/interceptor_data.dart#newcode38 pkg/compiler/lib/src/js_backend/interceptor_data.dart:38: bool mayGenerateInstanceofCheck(DartType type); +dartdoc: /// Whether the compiler ...
3 years, 9 months ago (2017-03-14 03:18:18 UTC) #3
Johnni Winther
https://codereview.chromium.org/2732663002/diff/20001/pkg/compiler/lib/src/js_backend/interceptor_data.dart File pkg/compiler/lib/src/js_backend/interceptor_data.dart (right): https://codereview.chromium.org/2732663002/diff/20001/pkg/compiler/lib/src/js_backend/interceptor_data.dart#newcode38 pkg/compiler/lib/src/js_backend/interceptor_data.dart:38: bool mayGenerateInstanceofCheck(DartType type); On 2017/03/14 03:18:18, Siggi Cherem (dart-lang) ...
3 years, 9 months ago (2017-03-15 09:49:01 UTC) #4
Johnni Winther
3 years, 9 months ago (2017-03-15 09:53:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c7011e2d825a7cc1fb22cc2fe7c50b8601909832 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698