Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 2732663002: Late creation of CodegenEnqueuer (Closed)
Patch Set: Updated cf. comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/enqueue.dart ('k') | pkg/compiler/lib/src/js_backend/interceptor_data.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart
index 09a34940d74b3891cca16270514ae3e5fcc7f788..4cfc293375165c352343f08afd9a0f57d4d194b9 100644
--- a/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/pkg/compiler/lib/src/js_backend/backend.dart
@@ -966,8 +966,6 @@ class JavaScriptBackend {
bool isComplexNoSuchMethod(FunctionElement element) =>
noSuchMethodRegistry.isComplex(element);
- CodegenEnqueuer get codegenEnqueuer => compiler.enqueuer.codegen;
-
/// Creates an [Enqueuer] for code generation specific to this backend.
CodegenEnqueuer createCodegenEnqueuer(CompilerTask task, Compiler compiler) {
return new CodegenEnqueuer(
@@ -1131,16 +1129,6 @@ class JavaScriptBackend {
element == helpers.jsUnmodifiableArrayClass;
}
- bool mayGenerateInstanceofCheck(ResolutionDartType type) {
- // We can use an instanceof check for raw types that have no subclass that
- // is mixed-in or in an implements clause.
-
- if (!type.isRaw) return false;
- ClassElement classElement = type.element;
- if (interceptorData.isInterceptedClass(classElement)) return false;
- return _closedWorld.hasOnlySubclasses(classElement);
- }
-
/// This method is called immediately after the [library] and its parts have
/// been scanned.
Future onLibraryScanned(LibraryElement library, LibraryLoader loader) {
@@ -1251,11 +1239,12 @@ class JavaScriptBackend {
/// Called when the compiler starts running the codegen enqueuer. The
/// [WorldImpact] of enabled backend features is returned.
- WorldImpact onCodegenStart(ClosedWorld closedWorld) {
+ WorldImpact onCodegenStart(
+ ClosedWorld closedWorld, CodegenWorldBuilder codegenWorldBuilder) {
_closedWorld = closedWorld;
- _namer = determineNamer(_closedWorld, compiler.codegenWorldBuilder);
- tracer = new Tracer(_closedWorld, namer, compiler);
- emitter.createEmitter(_namer, _closedWorld);
+ _namer = determineNamer(closedWorld, codegenWorldBuilder);
+ tracer = new Tracer(closedWorld, namer, compiler);
+ emitter.createEmitter(_namer, closedWorld);
_rtiEncoder =
_namer.rtiEncoder = new _RuntimeTypesEncoder(_namer, emitter, helpers);
« no previous file with comments | « pkg/compiler/lib/src/enqueue.dart ('k') | pkg/compiler/lib/src/js_backend/interceptor_data.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698