components/favicon/content/content_favicon_driver.h - Issue 2732653002: Add favicon integration tests for FaviconDriverImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/content/content_favicon_driver.h

Issue 2732653002: Add favicon integration tests for FaviconDriverImpl (Closed)

Patch Set: Added verification of color Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon/content/content_favicon_driver.h

diff --git a/components/favicon/content/content_favicon_driver.h b/components/favicon/content/content_favicon_driver.h

index 4b1b79b65ada76ce315cccc319af3d49c59b7fc2..717ffb11fb1d43d293aa789e3643680abf022b2e 100644

--- a/components/favicon/content/content_favicon_driver.h

+++ b/components/favicon/content/content_favicon_driver.h

@@ -44,8 +44,6 @@ class ContentFaviconDriver

// FaviconDriver implementation.

gfx::Image GetFavicon() const override;

- bool FaviconIsValid() const override;

- GURL GetActiveURL() override;

protected:

ContentFaviconDriver(content::WebContents* web_contents,