Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5019)

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 2732653002: Add favicon integration tests for FaviconDriverImpl (Closed)
Patch Set: Added verification of color Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/favicon/content/content_favicon_driver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_browsertest.cc
diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc
index 991e8f7fb53b14a7baaf2865dffd66fb69a5d875..ddb911b278dacb6faefaf861916ec37af0259bb1 100644
--- a/chrome/browser/prerender/prerender_browsertest.cc
+++ b/chrome/browser/prerender/prerender_browsertest.cc
@@ -2436,12 +2436,12 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderFavicon) {
favicon::FaviconDriver* favicon_driver =
favicon::ContentFaviconDriver::FromWebContents(GetActiveWebContents());
- if (!favicon_driver->FaviconIsValid()) {
+ if (favicon_driver->GetFavicon().IsEmpty()) {
// If the favicon has not been set yet, wait for it to be.
FaviconUpdateWatcher favicon_update_watcher(GetActiveWebContents());
favicon_update_watcher.Wait();
}
- EXPECT_TRUE(favicon_driver->FaviconIsValid());
+ EXPECT_FALSE(favicon_driver->GetFavicon().IsEmpty());
}
// Checks that when prerendered page is swapped in and the referring page
« no previous file with comments | « no previous file | components/favicon/content/content_favicon_driver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698