Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2732643004: Add operator<< to SelectionState for debug logging. (Closed)

Created:
3 years, 9 months ago by wkorman
Modified:
3 years, 9 months ago
Reviewers:
yosin_UTC9, pdr., Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add operator<< to SelectionState for debug logging. Review-Url: https://codereview.chromium.org/2732643004 Cr-Commit-Position: refs/heads/master@{#455338} Committed: https://chromium.googlesource.com/chromium/src/+/eabc10e7801155a68e5b787b61a92c735ea8f876

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use FOR_EACH pattern and add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -13 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/SelectionState.h View 1 1 chunk +23 lines, -13 lines 0 comments Download
A third_party/WebKit/Source/core/layout/api/SelectionState.cpp View 1 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/api/SelectionStateTest.cpp View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (4 generated)
wkorman
While working on text selection I've repeatedly found I have to painfully map selection state ...
3 years, 9 months ago (2017-03-04 00:11:10 UTC) #2
Xianzhu
On 2017/03/04 00:11:10, wkorman wrote: > While working on text selection I've repeatedly found I ...
3 years, 9 months ago (2017-03-04 00:30:56 UTC) #3
yosin_UTC9
I prefer removing #ifdef too. If we care about binary size. It is better to ...
3 years, 9 months ago (2017-03-06 04:51:10 UTC) #4
yosin_UTC9
Yet another usage of FOR_EACH_XXX() with operator<<() https://codereview.chromium.org/2727673005 It seems using DCHECK_GT() and DCHECK_LT() are ...
3 years, 9 months ago (2017-03-06 05:00:09 UTC) #5
Xianzhu
After looking at other similar situations, I prefer to define toString() and then operator<<() which ...
3 years, 9 months ago (2017-03-06 05:54:05 UTC) #6
Xianzhu
On 2017/03/06 05:54:05, Xianzhu wrote: > After looking at other similar situations, I prefer to ...
3 years, 9 months ago (2017-03-06 06:11:29 UTC) #7
wkorman
On 2017/03/06 06:11:29, Xianzhu wrote: > On 2017/03/06 05:54:05, Xianzhu wrote: > > After looking ...
3 years, 9 months ago (2017-03-07 22:02:08 UTC) #8
Xianzhu
On 2017/03/07 22:02:08, wkorman wrote: > On 2017/03/06 06:11:29, Xianzhu wrote: > > On 2017/03/06 ...
3 years, 9 months ago (2017-03-07 22:14:57 UTC) #9
wkorman
On 2017/03/07 22:14:57, Xianzhu wrote: > I'm not a big fan of FOR_EACH_XXX() if it ...
3 years, 9 months ago (2017-03-07 22:57:13 UTC) #10
Xianzhu
On 2017/03/07 22:57:13, wkorman wrote: > On 2017/03/07 22:14:57, Xianzhu wrote: > > I'm not ...
3 years, 9 months ago (2017-03-07 23:05:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732643004/20001
3 years, 9 months ago (2017-03-07 23:13:27 UTC) #13
pdr.
On 2017/03/07 at 23:13:27, commit-bot wrote: > CQ is trying da patch. Follow status at ...
3 years, 9 months ago (2017-03-08 00:06:01 UTC) #14
yosin_UTC9
On 2017/03/08 at 00:06:01, pdr wrote: > On 2017/03/07 at 23:13:27, commit-bot wrote: > > ...
3 years, 9 months ago (2017-03-08 01:09:21 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 01:56:37 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eabc10e7801155a68e5b787b61a9...

Powered by Google App Engine
This is Rietveld 408576698