Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2732633004: Turn on preload WPT tests (Closed)

Created:
3 years, 9 months ago by Yoav Weiss
Modified:
3 years, 9 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn on preload WPT tests This CL turns on WPT preload tests and fixes tests that failed due to missing font resource. BUG=698529 Review-Url: https://codereview.chromium.org/2732633004 Cr-Commit-Position: refs/heads/master@{#454779} Committed: https://chromium.googlesource.com/chromium/src/+/f28287ce594e559cdcf49ce4ec0b1dcc9e9100ec

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1

Messages

Total messages: 25 (15 generated)
Yoav Weiss
3 years, 9 months ago (2017-03-04 20:46:15 UTC) #9
Yoav Weiss
qyearsley/foolip - can you take a look at the exported tests and make sure I ...
3 years, 9 months ago (2017-03-04 20:58:31 UTC) #11
Charlie Harrison
LGTM but would you add a BUG= and describe which issue you are fixing with ...
3 years, 9 months ago (2017-03-04 21:35:51 UTC) #12
Yoav Weiss
On 2017/03/04 21:35:51, Charlie Harrison wrote: > LGTM but would you add a BUG= and ...
3 years, 9 months ago (2017-03-04 21:56:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732633004/20001
3 years, 9 months ago (2017-03-04 21:56:27 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f28287ce594e559cdcf49ce4ec0b1dcc9e9100ec
3 years, 9 months ago (2017-03-04 22:00:23 UTC) #21
Yoav Weiss
On 2017/03/04 22:00:23, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) as ...
3 years, 9 months ago (2017-03-04 22:38:47 UTC) #22
Erikkagail
On 2017/03/04 21:35:51, Charlie Harrison wrote: > LGTM but would you add a BUG= and ...
3 years, 9 months ago (2017-03-04 22:40:58 UTC) #23
qyearsley
LGTM, and glad it looks like it was exported properly :-) https://codereview.chromium.org/2732633004/diff/20001/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): ...
3 years, 9 months ago (2017-03-05 00:43:43 UTC) #24
Yoav Weiss
3 years, 9 months ago (2017-03-05 07:37:52 UTC) #25
Message was sent while issue was closed.
On 2017/03/05 00:43:43, qyearsley wrote:
> LGTM, and glad it looks like it was exported properly :-)
> 
>
https://codereview.chromium.org/2732633004/diff/20001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/TestExpectations (right):
> 
>
https://codereview.chromium.org/2732633004/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/TestExpectations:2509: crbug.com/698521
> external/wpt/preload/preload-with-type.html [ Failure Pass ]
> Are these flaky or consistently failing?

Consistently failing for now (Got a CL fixing that, pending on a spec change)

Powered by Google App Engine
This is Rietveld 408576698