Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2732613002: [ic] Mark labels as deferred (Closed)

Created:
3 years, 9 months ago by jgruber
Modified:
3 years, 9 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Mark labels as deferred This should improve generated code. It is also one step in preparation for LoadIC inlining - explicitly deferred blocks are currently necessary to help the scheduler omit frame construction. BUG=v8:5917 Review-Url: https://codereview.chromium.org/2732613002 Cr-Commit-Position: refs/heads/master@{#43577} Committed: https://chromium.googlesource.com/v8/v8/+/f7bc5ef0bc6f4c2f6d1edcf31b064cf760cc54a1

Patch Set 1 #

Patch Set 2 : Don't defer HandlePolymorphicCase loop labels #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -27 lines) Patch
M src/ic/accessor-assembler.cc View 1 7 chunks +21 lines, -27 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
jgruber
3 years, 9 months ago (2017-03-03 09:03:29 UTC) #4
Igor Sheludko
lgtm
3 years, 9 months ago (2017-03-03 09:51:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732613002/20001
3 years, 9 months ago (2017-03-03 10:41:53 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 10:43:40 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/f7bc5ef0bc6f4c2f6d1edcf31b064cf760c...

Powered by Google App Engine
This is Rietveld 408576698