Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2732533002:
Remove a redundant clear() call (Closed)
DescriptionRemove a redundant clear() call
PVS-Studio pointed out that the "clear" function is called twice for
deallocation of the same resource in query_manager.cc. The redundant
one should be removed.
BUG=697659
Review-Url: https://codereview.chromium.org/2732533002
Cr-Commit-Position: refs/heads/master@{#454459}
Committed: https://chromium.googlesource.com/chromium/src/+/9f12d3c9c6e6d3b26750b4e897cdd3d7fb5972b0
Patch Set 1 #
Messages
Total messages: 17 (13 generated)
The CQ bit was checked by chengx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
Description was changed from ========== Remove redudant clear() call. BUG=697659 ========== to ========== Remove a redundant clear() call. PVS-Studio pointed out that the "clear" function is called twice for deallocation of the same resource in query_manager.cc. The redundant one should be removed. BUG=697659 ==========
Description was changed from ========== Remove a redundant clear() call. PVS-Studio pointed out that the "clear" function is called twice for deallocation of the same resource in query_manager.cc. The redundant one should be removed. BUG=697659 ========== to ========== Remove a redundant clear() call. PVS-Studio pointed out that the "clear" function is called twice for deallocation of the same resource in query_manager.cc. The redundant one should be removed. BUG=697659 ==========
Description was changed from ========== Remove a redundant clear() call. PVS-Studio pointed out that the "clear" function is called twice for deallocation of the same resource in query_manager.cc. The redundant one should be removed. BUG=697659 ========== to ========== Remove a redundant clear() call. PVS-Studio pointed out that the "clear" function is called twice for deallocation of the same resource in query_manager.cc. The redundant one should be removed. BUG=697659 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
chengx@chromium.org changed reviewers: + jbauman@chromium.org
PTAL~
Description was changed from ========== Remove a redundant clear() call. PVS-Studio pointed out that the "clear" function is called twice for deallocation of the same resource in query_manager.cc. The redundant one should be removed. BUG=697659 ========== to ========== Remove a redundant clear() call PVS-Studio pointed out that the "clear" function is called twice for deallocation of the same resource in query_manager.cc. The redundant one should be removed. BUG=697659 ==========
lgtm
The CQ bit was checked by chengx@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488501096604070,
"parent_rev": "46453b459c4177890df3b937b6256bbc1d92e266", "commit_rev":
"9f12d3c9c6e6d3b26750b4e897cdd3d7fb5972b0"}
Message was sent while issue was closed.
Description was changed from ========== Remove a redundant clear() call PVS-Studio pointed out that the "clear" function is called twice for deallocation of the same resource in query_manager.cc. The redundant one should be removed. BUG=697659 ========== to ========== Remove a redundant clear() call PVS-Studio pointed out that the "clear" function is called twice for deallocation of the same resource in query_manager.cc. The redundant one should be removed. BUG=697659 Review-Url: https://codereview.chromium.org/2732533002 Cr-Commit-Position: refs/heads/master@{#454459} Committed: https://chromium.googlesource.com/chromium/src/+/9f12d3c9c6e6d3b26750b4e897cd... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/9f12d3c9c6e6d3b26750b4e897cd... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
