Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: third_party/WebKit/Source/modules/webaudio/ConvolverNode.h

Issue 2732523003: Make ConvolverNode conform to spec (Closed)
Patch Set: Remove unneeded numberOfChannels parameter and simplify code Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/ConvolverNode.h
diff --git a/third_party/WebKit/Source/modules/webaudio/ConvolverNode.h b/third_party/WebKit/Source/modules/webaudio/ConvolverNode.h
index 90857b3f8c424653680cdba1ad4d123cdcfb51ac..ba221ab31a1e49989a9ba11510657337fab2a120 100644
--- a/third_party/WebKit/Source/modules/webaudio/ConvolverNode.h
+++ b/third_party/WebKit/Source/modules/webaudio/ConvolverNode.h
@@ -47,6 +47,9 @@ class MODULES_EXPORT ConvolverHandler final : public AudioHandler {
// AudioHandler
void process(size_t framesToProcess) override;
+ // Called in the main thread when the number of channels for the input may
+ // have changed.
+ void checkNumberOfChannelsForInput(AudioNodeInput*) override;
// Impulse responses
void setBuffer(AudioBuffer*, ExceptionState&);
@@ -54,6 +57,8 @@ class MODULES_EXPORT ConvolverHandler final : public AudioHandler {
bool normalize() const { return m_normalize; }
void setNormalize(bool normalize) { m_normalize = normalize; }
+ void setChannelCount(unsigned long, ExceptionState&) final;
+ void setChannelCountMode(const String&, ExceptionState&) final;
private:
ConvolverHandler(AudioNode&, float sampleRate);

Powered by Google App Engine
This is Rietveld 408576698