Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html

Issue 2732523003: Make ConvolverNode conform to spec (Closed)
Patch Set: Remove unneeded numberOfChannels parameter and simplify code Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html b/third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html
index f48c95a4fd5b7e45502a48fd84044f2a3da7eb20..410869d2afc9569ed51e4e105050407e46288c87 100644
--- a/third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html
+++ b/third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html
@@ -62,7 +62,7 @@
success = Should("node0.channelInterpretation", node.channelInterpretation)
.beEqualTo("speakers") && success;
- success = Should("new AnalyserNode(context)", success)
+ success = Should("new ConvolverNode(context)", success)
.summarize(
"constructed node with correct attributes",
"did not construct correct node correctly")
@@ -71,7 +71,18 @@
});
audit.defineTask("test AudioNodeOptions", function (taskDone) {
- testAudioNodeOptions(context, "ConvolverNode");
+ testAudioNodeOptions(context, "ConvolverNode", {
+ expectedChannelCount: {
+ value: 2,
+ isFixed: true,
+ errorType: "NotSupportedError"
+ },
+ expectedChannelCountMode: {
+ value: "clamped-max",
+ isFixed: true,
+ errorType: "NotSupportedError"
+ },
+ });
taskDone();
});

Powered by Google App Engine
This is Rietveld 408576698