third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html - Issue 2732523003: Make ConvolverNode conform to spec

Side by Side Diff: third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html

Issue 2732523003: Make ConvolverNode conform to spec (Closed)

Patch Set: Remove unneeded numberOfChannels parameter and simplify code Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-response-4-chan.html ('k') | third_party/WebKit/Source/modules/webaudio/ConvolverNode.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Test Constructor: Convolver</title>	4 <title>Test Constructor: Convolver</title>

5 <script src="../../resources/testharness.js"></script>	5 <script src="../../resources/testharness.js"></script>

6 <script src="../../resources/testharnessreport.js"></script>	6 <script src="../../resources/testharnessreport.js"></script>

7 <script src="../resources/audit-util.js"></script>	7 <script src="../resources/audit-util.js"></script>

8 <script src="../resources/audio-testing.js"></script>	8 <script src="../resources/audio-testing.js"></script>

9 <script src="audionodeoptions.js"></script>	9 <script src="audionodeoptions.js"></script>

10 </head>	10 </head>

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55 success = Should("node0.normalize", node.normalize)	55 success = Should("node0.normalize", node.normalize)

56 .beEqualTo(true) && success;	56 .beEqualTo(true) && success;

57	57

58 success = Should("node0.channelCount", node.channelCount)	58 success = Should("node0.channelCount", node.channelCount)

59 .beEqualTo(2) && success;	59 .beEqualTo(2) && success;

60 success = Should("node0.channelCountMode", node.channelCountMode)	60 success = Should("node0.channelCountMode", node.channelCountMode)

61 .beEqualTo("clamped-max") && success;	61 .beEqualTo("clamped-max") && success;

62 success = Should("node0.channelInterpretation", node.channelInterpretati on)	62 success = Should("node0.channelInterpretation", node.channelInterpretati on)

63 .beEqualTo("speakers") && success;	63 .beEqualTo("speakers") && success;

64	64

65 success = Should("new AnalyserNode(context)", success)	65 success = Should("new ConvolverNode(context)", success)

66 .summarize(	66 .summarize(

67 "constructed node with correct attributes",	67 "constructed node with correct attributes",

68 "did not construct correct node correctly")	68 "did not construct correct node correctly")

69	69

70 taskDone();	70 taskDone();

71 });	71 });

72	72

73 audit.defineTask("test AudioNodeOptions", function (taskDone) {	73 audit.defineTask("test AudioNodeOptions", function (taskDone) {

74 testAudioNodeOptions(context, "ConvolverNode");	74 testAudioNodeOptions(context, "ConvolverNode", {

	75 expectedChannelCount: {

	76 value: 2,

	77 isFixed: true,

	78 errorType: "NotSupportedError"

	79 },

	80 expectedChannelCountMode: {

	81 value: "clamped-max",

	82 isFixed: true,

	83 errorType: "NotSupportedError"

	84 },

	85 });

75 taskDone();	86 taskDone();

76 });	87 });

77	88

78 audit.defineTask("nullable buffer", function (taskDone) {	89 audit.defineTask("nullable buffer", function (taskDone) {

79 var node;	90 var node;

80 var success = true;	91 var success = true;

81	92

82 var options = { buffer: null };	93 var options = { buffer: null };

83	94

84 success = Should("node1 = new ConvolverNode(c, " + JSON.stringify(option s), function () {	95 success = Should("node1 = new ConvolverNode(c, " + JSON.stringify(option s), function () {

(...skipping 60 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
145 "constructed with correct attributes",	156 "constructed with correct attributes",

146 "was not constructed correctly");	157 "was not constructed correctly");

147	158

148 taskDone();	159 taskDone();

149 });	160 });

150	161

151 audit.runTasks();	162 audit.runTasks();

152 </script>	163 </script>

153 </body>	164 </body>

154 </html>	165 </html>

OLD	NEW