Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2732513002: CookieStoreIOS should consider SystemCookiesAllowed unless system cookies policy is set to never. (Closed)

Created:
3 years, 9 months ago by mef
Modified:
3 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

CookieStoreIOS should consider SystemCookiesAllowed unless system cookies policy is set to never. BUG=679736 Review-Url: https://codereview.chromium.org/2732513002 Cr-Commit-Position: refs/heads/master@{#454402} Committed: https://chromium.googlesource.com/chromium/src/+/785bf143e2dd152e2a7deaa86f7ca39a46eb624a CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/net/cookies/cookie_store_ios.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
mef
PTAL, this is to fix a crash in Cronet consumer.
3 years, 9 months ago (2017-03-02 19:56:59 UTC) #3
Eugene But (OOO till 7-30)
lgtm, I guess... Adding David, who may actually be familiar with this code.
3 years, 9 months ago (2017-03-02 20:55:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732513002/1
3 years, 9 months ago (2017-03-02 22:11:24 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/785bf143e2dd152e2a7deaa86f7ca39a46eb624a
3 years, 9 months ago (2017-03-02 22:18:55 UTC) #14
droger
3 years, 9 months ago (2017-03-03 12:56:49 UTC) #15
Message was sent while issue was closed.
This should be fine, although I don't think it will make any difference for
Chrome in practice.

Powered by Google App Engine
This is Rietveld 408576698