Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2732493002: Vector icons: fix R_MOVE_TO after CLOSE (Closed)

Created:
3 years, 9 months ago by Evan Stade
Modified:
3 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Vector icons: fix R_MOVE_TO after CLOSE This might affect some pre-existing vector icons, and in fact I found many that have a R_MOVE_TO right after a CLOSE. But all the ones I checked didn't exhibit the bug because the current subpath already happened to start and finish in the same place. BUG=697497 Review-Url: https://codereview.chromium.org/2732493002 Cr-Commit-Position: refs/heads/master@{#454666} Committed: https://chromium.googlesource.com/chromium/src/+/c570b631a9db029a57a73d0b4068d2f625795135

Patch Set 1 #

Patch Set 2 : fix up test #

Patch Set 3 : constify #

Total comments: 2

Patch Set 4 : move include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -1 line) Patch
M ui/gfx/BUILD.gn View 1 1 chunk +4 lines, -1 line 0 comments Download
M ui/gfx/paint_vector_icon.cc View 1 chunk +7 lines, -0 lines 0 comments Download
A ui/gfx/paint_vector_icon_unittest.cc View 1 2 3 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
Evan Stade
3 years, 9 months ago (2017-03-02 18:45:35 UTC) #3
sky
LGTM https://codereview.chromium.org/2732493002/diff/40001/ui/gfx/paint_vector_icon_unittest.cc File ui/gfx/paint_vector_icon_unittest.cc (right): https://codereview.chromium.org/2732493002/diff/40001/ui/gfx/paint_vector_icon_unittest.cc#newcode11 ui/gfx/paint_vector_icon_unittest.cc:11: #include "ui/gfx/paint_vector_icon.h" Make this your first include.
3 years, 9 months ago (2017-03-02 20:13:26 UTC) #6
Evan Stade
https://codereview.chromium.org/2732493002/diff/40001/ui/gfx/paint_vector_icon_unittest.cc File ui/gfx/paint_vector_icon_unittest.cc (right): https://codereview.chromium.org/2732493002/diff/40001/ui/gfx/paint_vector_icon_unittest.cc#newcode11 ui/gfx/paint_vector_icon_unittest.cc:11: #include "ui/gfx/paint_vector_icon.h" On 2017/03/02 20:13:26, sky wrote: > Make ...
3 years, 9 months ago (2017-03-03 00:08:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732493002/60001
3 years, 9 months ago (2017-03-03 00:09:09 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/333087) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 9 months ago (2017-03-03 01:17:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732493002/60001
3 years, 9 months ago (2017-03-03 01:24:10 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/320406) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 9 months ago (2017-03-03 01:30:43 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732493002/60001
3 years, 9 months ago (2017-03-03 20:21:35 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 20:49:57 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c570b631a9db029a57a73d0b4068...

Powered by Google App Engine
This is Rietveld 408576698