Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 2732413002: Fix mocking on native classes (Closed)

Created:
3 years, 9 months ago by vsm
Modified:
3 years, 9 months ago
Reviewers:
Jacob
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -34 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 10 chunks +70 lines, -8 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 10 chunks +70 lines, -8 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 10 chunks +70 lines, -8 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 10 chunks +70 lines, -8 lines 0 comments Download
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/lib/src/compiler/extension_types.dart View 1 chunk +1 line, -1 line 1 comment Download
M tests/lib_strong/html/html_mock_test.dart View 3 chunks +43 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
https://codereview.chromium.org/2732413002/diff/1/pkg/dev_compiler/lib/src/compiler/extension_types.dart File pkg/dev_compiler/lib/src/compiler/extension_types.dart (left): https://codereview.chromium.org/2732413002/diff/1/pkg/dev_compiler/lib/src/compiler/extension_types.dart#oldcode165 pkg/dev_compiler/lib/src/compiler/extension_types.dart:165: if (_isNativeInterface(element)) types.add(element); This was missing types like "Window"
3 years, 9 months ago (2017-03-07 23:26:47 UTC) #3
Jacob
lgtm!
3 years, 9 months ago (2017-03-07 23:28:49 UTC) #4
vsm
3 years, 9 months ago (2017-03-07 23:33:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
01508dd2e238a4c4eb33a909373a4e3bc4cdec45 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698