Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/dev_compiler/lib/src/compiler/extension_types.dart

Issue 2732413002: Fix mocking on native classes (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dev_compiler/lib/sdk/ddc_sdk.sum ('k') | tests/lib_strong/html/html_mock_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/lib/src/compiler/extension_types.dart
diff --git a/pkg/dev_compiler/lib/src/compiler/extension_types.dart b/pkg/dev_compiler/lib/src/compiler/extension_types.dart
index 2a3826c19b04303adaa607f6c226f7884a721be5..7afb9f38a5127a8f9fbe47df2d6c0cbef6defce6 100644
--- a/pkg/dev_compiler/lib/src/compiler/extension_types.dart
+++ b/pkg/dev_compiler/lib/src/compiler/extension_types.dart
@@ -162,7 +162,7 @@ class ExtensionTypeSet {
void _collectNativeInterfaces(InterfaceType type, Set<ClassElement> types) {
if (type.isObject) return;
var element = type.element;
- if (_isNativeInterface(element)) types.add(element);
vsm 2017/03/07 23:26:46 This was missing types like "Window"
+ if (hasNativeSubtype(type)) types.add(element);
for (var m in element.mixins.reversed) {
_collectNativeInterfaces(m, types);
}
« no previous file with comments | « pkg/dev_compiler/lib/sdk/ddc_sdk.sum ('k') | tests/lib_strong/html/html_mock_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698