third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.h - Issue 2732363003: Make TopDocumentRootScrollerController store Page instead of FrameHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.h

Issue 2732363003: Make TopDocumentRootScrollerController store Page instead of FrameHost (Closed)

Patch Set: Review feedback Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameHost.cpp ('k') | third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp » ('j') | third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.h

diff --git a/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.h b/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.h

index 58cc5e76d27aec242552e9c05f23a88df192714e..cf5917f743ae4bfce734db0a997115746a376664 100644

--- a/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.h

+++ b/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.h

@@ -13,7 +13,7 @@

namespace blink {

class Element;

-class FrameHost;

+class Page;

class GraphicsLayer;

class PaintLayer;

class RootFrameViewport;

@@ -30,7 +30,7 @@ class ViewportScrollCallback;

class CORE_EXPORT TopDocumentRootScrollerController

: public GarbageCollected<TopDocumentRootScrollerController> {

public:

- static TopDocumentRootScrollerController* create(FrameHost&);

+ static TopDocumentRootScrollerController* create(Page&);

DECLARE_TRACE();

@@ -78,7 +78,7 @@ class CORE_EXPORT TopDocumentRootScrollerController

IntSize rootScrollerVisibleArea() const;

private:

- TopDocumentRootScrollerController(FrameHost&);

+ TopDocumentRootScrollerController(Page&);

// Calculates the Element that should be the globalRootScroller. On a

// simple page, this will simply the root frame's effectiveRootScroller but

@@ -106,7 +106,7 @@ class CORE_EXPORT TopDocumentRootScrollerController

// Element.

WeakMember<Element> m_globalRootScroller;

- WeakMember<FrameHost> m_frameHost;

+ WeakMember<Page> m_page;

haraken 2017/03/08 06:15:48 Not related to this CL, I don't understand why thi

sashab 2017/03/08 23:39:31 Haha, I thought the same thing when I saw this! Le

};

} // namespace blink