third_party/WebKit/Source/core/frame/FrameHost.cpp - Issue 2732363003: Make TopDocumentRootScrollerController store Page instead of FrameHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameHost.cpp

Issue 2732363003: Make TopDocumentRootScrollerController store Page instead of FrameHost (Closed)

Patch Set: Review feedback Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameHost.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameHost.cpp b/third_party/WebKit/Source/core/frame/FrameHost.cpp

index c8393af9e00a5cc04cbeac6c1484c57163844ace..f11a6eef0e60890ea0d1cf2a379b7bbec0f4408f 100644

--- a/third_party/WebKit/Source/core/frame/FrameHost.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameHost.cpp

@@ -57,7 +57,7 @@ FrameHost::FrameHost(Page& page)

m_eventHandlerRegistry(new EventHandlerRegistry(*this)),

m_consoleMessageStorage(new ConsoleMessageStorage()),

m_globalRootScrollerController(

- TopDocumentRootScrollerController::create(*this)),

+ TopDocumentRootScrollerController::create(page)),

m_subframeCount(0) {}

// Explicitly in the .cpp to avoid default constructor in .h