Issue 273233004: Fix some more tests that were writing to the user's home directory.

Issue 273233004: Fix some more tests that were writing to the user's home directory. (Closed)

Created:
6 years, 7 months ago by asanka

Modified:
6 years, 7 months ago

Reviewers:
Bernhard Bauer, Joao da Silva, jam

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix some more tests that were writing to the user's home directory. The tests affected are: PolicyTest.ExtensionInstallSources PrefsFunctionalTest.TestDownloadDirPref WebNavigationApiTest.Download BUG=372017 R=bauerb@chromium.org TBR=jam, joaodasilva Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269639

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -15 lines)			Patch
M	chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/policy_browsertest.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/prefs/pref_functional_browsertest.cc	View	1	1 chunk	+4 lines, -15 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Bernhard Bauer

LGTM! https://codereview.chromium.org/273233004/diff/1/chrome/browser/prefs/pref_functional_browsertest.cc File chrome/browser/prefs/pref_functional_browsertest.cc (right): https://codereview.chromium.org/273233004/diff/1/chrome/browser/prefs/pref_functional_browsertest.cc#newcode52 chrome/browser/prefs/pref_functional_browsertest.cc:52: base::FilePath download_dir = Is this still required?

6 years, 7 months ago (2014-05-10 15:35:56 UTC) #3

asanka

Thanks! https://codereview.chromium.org/273233004/diff/1/chrome/browser/prefs/pref_functional_browsertest.cc File chrome/browser/prefs/pref_functional_browsertest.cc (right): https://codereview.chromium.org/273233004/diff/1/chrome/browser/prefs/pref_functional_browsertest.cc#newcode52 chrome/browser/prefs/pref_functional_browsertest.cc:52: base::FilePath download_dir = On 2014/05/10 15:35:56, Bernhard Bauer ...

6 years, 7 months ago (2014-05-10 18:52:55 UTC) #4

asanka

jam, joaodasilva: I'll TBR this in the interest of fixing the waterfall. Please review when ...

6 years, 7 months ago (2014-05-10 21:26:02 UTC) #5

asanka

Committed patchset #2 manually as r269639 (tree was closed).

6 years, 7 months ago (2014-05-10 21:31:51 UTC) #6

Message was sent while issue was closed.

lgtm, thanks for fixing

Expand Messages | Collapse Messages