Fix some more tests that were writing to the user's home directory.

chrome/browser/prefs/pref_functional_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/path_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/download/download_prefs.h"
 #include "chrome/browser/prefs/pref_service_syncable.h"
@@ skipping 26 matching lines @@
          new content::DownloadTestObserverTerminal(
              download_manager,
              num_downloads,
              content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL);
     return make_scoped_ptr(downloads_observer);
   }
 };
 
 IN_PROC_BROWSER_TEST_F(PrefsFunctionalTest, TestDownloadDirPref) {
   ASSERT_TRUE(test_server()->Start());
+  base::ScopedTempDir new_download_dir;
+  ASSERT_TRUE(new_download_dir.CreateUniqueTempDir());
 
   DownloadManager* download_manager =
       BrowserContext::GetDownloadManager(browser()->profile());
   base::FilePath download_dir =

[Bernhard Bauer, 2014/05/10 15:35:56]

Is this still required?

[asanka, 2014/05/10 18:52:55]

Removed. Thanks!

       (DownloadPrefs::FromDownloadManager(download_manager))->DownloadPath();
-  base::FilePath new_download_dir = download_dir.AppendASCII("my_downloads");
   base::FilePath downloaded_pkg =
-      new_download_dir.AppendASCII("a_zip_file.zip");
+      new_download_dir.path().AppendASCII("a_zip_file.zip");
 
-  // If the directory exists, delete it.
-  if (base::PathExists(new_download_dir)) {
-    base::DeleteFile(new_download_dir, true);
-  }
-
-  // Create the new downloads directory.
-  base::CreateDirectory(new_download_dir);
   // Set pref to download in new_download_dir.
   browser()->profile()->GetPrefs()->SetFilePath(
-      prefs::kDownloadDefaultDirectory,
-      new_download_dir);
+      prefs::kDownloadDefaultDirectory, new_download_dir.path());
 
   // Create a downloads observer.
   scoped_ptr<content::DownloadTestObserver> downloads_observer(
       CreateWaiter(browser(), 1));
   ui_test_utils::NavigateToURL(
       browser(),
       test_server()->GetURL("files/downloads/a_zip_file.zip"));
   // Waits for the download to complete.
   downloads_observer->WaitForFinished();
   EXPECT_TRUE(base::PathExists(downloaded_pkg));
@@ skipping 169 matching lines @@
   EXPECT_FALSE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled));
   EXPECT_FALSE(prefs->GetBoolean(prefs::kAlternateErrorPagesEnabled));
   EXPECT_FALSE(prefs->GetBoolean(prefs::kSearchSuggestEnabled));
 }
 
 // Verify that we have some Local State prefs.
 IN_PROC_BROWSER_TEST_F(PrefsFunctionalTest, TestHaveLocalStatePrefs) {
   EXPECT_TRUE(g_browser_process->local_state()->GetPreferenceValues().get());
 }