Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1777)

Unified Diff: chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc

Issue 2732293003: Adding UMA on page load size for pages with Media (Closed)
Patch Set: bmcquade comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d8e9e8c574e435a4ba2b7654605ef6323a254bf5
--- /dev/null
+++ b/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc
@@ -0,0 +1,150 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.h"
+
+#include <memory>
+
+#include "base/macros.h"
+#include "base/memory/ptr_util.h"
+#include "base/test/histogram_tester.h"
+#include "base/time/time.h"
+#include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h"
+#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
+#include "chrome/common/page_load_metrics/page_load_timing.h"
+#include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h"
+#include "url/gurl.h"
+
+namespace {
+
+const char kDefaultTestUrl[] = "https://google.com";
+
+} // namespace
+
+class MediaPageLoadMetricsObserverTest
+ : public page_load_metrics::PageLoadMetricsObserverTestHarness {
+ public:
+ MediaPageLoadMetricsObserverTest() {}
+ ~MediaPageLoadMetricsObserverTest() override = default;
+
+ void ResetTest() {
+ // Reset to the default testing state. Does not reset histogram state.
+ timing_.navigation_start = base::Time::FromDoubleT(1);
+ timing_.response_start = base::TimeDelta::FromSeconds(2);
+ timing_.parse_start = base::TimeDelta::FromSeconds(3);
+ timing_.first_contentful_paint = base::TimeDelta::FromSeconds(4);
+ timing_.first_image_paint = base::TimeDelta::FromSeconds(5);
+ timing_.first_text_paint = base::TimeDelta::FromSeconds(6);
+ timing_.load_event_start = base::TimeDelta::FromSeconds(7);
+ PopulateRequiredTimingFields(&timing_);
+
+ network_bytes_ = 0;
+ cache_bytes_ = 0;
+ }
+
+ void SimulatePageLoad(bool simulate_play_media,
+ bool simulate_app_background) {
+ NavigateAndCommit(GURL(kDefaultTestUrl));
+
+ if (simulate_play_media)
+ SimulateMediaPlayed();
+
+ SimulateTimingUpdate(timing_);
+
+ // Prepare 4 resources of varying size and configurations.
+ page_load_metrics::ExtraRequestInfo resources[] = {
+ // Cached request.
+ {true /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+ false /* data_reduction_proxy_used*/,
+ 0 /* original_network_content_length */},
+ // Uncached non-proxied request.
+ {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+ false /* data_reduction_proxy_used*/,
+ 1024 * 40 /* original_network_content_length */},
+ // Uncached proxied request with .1 compression ratio.
+ {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+ false /* data_reduction_proxy_used*/,
+ 1024 * 40 /* original_network_content_length */},
+ // Uncached proxied request with .5 compression ratio.
+ {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+ false /* data_reduction_proxy_used*/,
+ 1024 * 40 /* original_network_content_length */},
+ };
+
+ for (auto request : resources) {
+ SimulateLoadedResource(request);
+ if (!request.was_cached) {
+ network_bytes_ += request.raw_body_bytes;
+ } else {
+ cache_bytes_ += request.raw_body_bytes;
+ }
+ }
+
+ if (simulate_app_background) {
+ // The histograms should be logged when the app is backgrounded.
+ SimulateAppEnterBackground();
+ } else {
+ NavigateToUntrackedUrl();
+ }
+ }
+
+ protected:
+ void RegisterObservers(page_load_metrics::PageLoadTracker* tracker) override {
+ tracker->AddObserver(base::MakeUnique<MediaPageLoadMetricsObserver>());
+ }
+
+ // Simulated byte usage since the last time the test was reset.
+ int64_t network_bytes_;
+ int64_t cache_bytes_;
+
+ private:
+ page_load_metrics::PageLoadTiming timing_;
+
+ DISALLOW_COPY_AND_ASSIGN(MediaPageLoadMetricsObserverTest);
+};
+
+TEST_F(MediaPageLoadMetricsObserverTest, MediaPlayed) {
+ ResetTest();
+ SimulatePageLoad(true /* simulate_play_media */,
+ false /* simulate_app_background */);
+
+ histogram_tester().ExpectUniqueSample(
+ "PageLoad.Clients.MediaPageLoad.Experimental.Bytes.Network",
+ static_cast<int>(network_bytes_ / 1024), 1);
+ histogram_tester().ExpectUniqueSample(
+ "PageLoad.Clients.MediaPageLoad.Experimental.Bytes.Cache",
+ static_cast<int>(cache_bytes_ / 1024), 1);
+ histogram_tester().ExpectUniqueSample(
+ "PageLoad.Clients.MediaPageLoad.Experimental.Bytes.Total",
+ static_cast<int>((network_bytes_ + cache_bytes_) / 1024), 1);
+}
+
+TEST_F(MediaPageLoadMetricsObserverTest, MediaPlayedAppBackground) {
+ ResetTest();
+ SimulatePageLoad(true /* simulate_play_media */,
+ true /* simulate_app_background */);
+
+ histogram_tester().ExpectUniqueSample(
+ "PageLoad.Clients.MediaPageLoad.Experimental.Bytes.Network",
+ static_cast<int>(network_bytes_ / 1024), 1);
+ histogram_tester().ExpectUniqueSample(
+ "PageLoad.Clients.MediaPageLoad.Experimental.Bytes.Cache",
+ static_cast<int>(cache_bytes_ / 1024), 1);
+ histogram_tester().ExpectUniqueSample(
+ "PageLoad.Clients.MediaPageLoad.Experimental.Bytes.Total",
+ static_cast<int>((network_bytes_ + cache_bytes_) / 1024), 1);
+}
+
+TEST_F(MediaPageLoadMetricsObserverTest, MediaNotPlayed) {
+ ResetTest();
+ SimulatePageLoad(false /* simulate_play_media */,
+ false /* simulate_app_background */);
+
+ histogram_tester().ExpectTotalCount(
+ "PageLoad.Clients.MediaPageLoad.Experimental.Bytes.Network", 0);
+ histogram_tester().ExpectTotalCount(
+ "PageLoad.Clients.MediaPageLoad.Experimental.Bytes.Cache", 0);
+ histogram_tester().ExpectTotalCount(
+ "PageLoad.Clients.MediaPageLoad.Experimental.Bytes.Total", 0);
+}

Powered by Google App Engine
This is Rietveld 408576698