Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5690)

Unified Diff: chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.cc

Issue 2732293003: Adding UMA on page load size for pages with Media (Closed)
Patch Set: bmcquade comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.cc
new file mode 100644
index 0000000000000000000000000000000000000000..6e73c491b3d181920b2c7f401bf84d09a21a68ad
--- /dev/null
+++ b/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.cc
@@ -0,0 +1,71 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer.h"
+
+#include "chrome/browser/page_load_metrics/page_load_metrics_util.h"
+#include "chrome/common/page_load_metrics/page_load_timing.h"
+
+namespace {
+
+const char kHistogramNetworkBytes[] =
+ "PageLoad.Clients.MediaPageLoad.Experimental.Bytes.Network";
+const char kHistogramCacheBytes[] =
+ "PageLoad.Clients.MediaPageLoad.Experimental.Bytes.Cache";
+const char kHistogramTotalBytes[] =
+ "PageLoad.Clients.MediaPageLoad.Experimental.Bytes.Total";
+
+} // namespace
+
+MediaPageLoadMetricsObserver::MediaPageLoadMetricsObserver()
+ : cache_bytes_(0), network_bytes_(0), played_media_(false) {}
+
+MediaPageLoadMetricsObserver::~MediaPageLoadMetricsObserver() = default;
+
+void MediaPageLoadMetricsObserver::OnLoadedResource(
+ const page_load_metrics::ExtraRequestInfo& extra_request_info) {
+ if (extra_request_info.was_cached) {
+ cache_bytes_ += extra_request_info.raw_body_bytes;
+ } else {
+ network_bytes_ += extra_request_info.raw_body_bytes;
+ }
+}
+
+page_load_metrics::PageLoadMetricsObserver::ObservePolicy
+MediaPageLoadMetricsObserver::FlushMetricsOnAppEnterBackground(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) {
+ // FlushMetricsOnAppEnterBackground is invoked on Android in cases where the
+ // app is about to be backgrounded, as part of the Activity.onPause()
+ // flow. After this method is invoked, Chrome may be killed without further
+ // notification, so we record final metrics collected up to this point.
+ if (info.did_commit && played_media_) {
+ RecordByteHistograms();
+ }
+ return STOP_OBSERVING;
+}
+
+void MediaPageLoadMetricsObserver::OnComplete(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) {
+ if (!played_media_)
+ return;
+ RecordByteHistograms();
+}
+
+void MediaPageLoadMetricsObserver::MediaStartedPlaying(
+ const content::WebContentsObserver::MediaPlayerInfo& video_type,
+ bool is_in_main_frame) {
+ if (played_media_)
+ return;
+ // Track media (audio or video) in all frames of the page load.
+ played_media_ = true;
+}
+
+void MediaPageLoadMetricsObserver::RecordByteHistograms() {
+ DCHECK(played_media_);
+ PAGE_BYTES_HISTOGRAM(kHistogramNetworkBytes, network_bytes_);
+ PAGE_BYTES_HISTOGRAM(kHistogramCacheBytes, cache_bytes_);
+ PAGE_BYTES_HISTOGRAM(kHistogramTotalBytes, network_bytes_ + cache_bytes_);
+}

Powered by Google App Engine
This is Rietveld 408576698