Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 2732283002: Rename WindowCompositorFrameSink To ClientCompositorFrameSink (Closed)

Created:
3 years, 9 months ago by Alex Z.
Modified:
3 years, 9 months ago
Reviewers:
Fady Samuel, sky
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, sadrul, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename WindowCompositorFrameSink To ClientCompositorFrameSink This name is more natural since it's the CompositorFrameSink running on the client side. BUG=683732 Review-Url: https://codereview.chromium.org/2732283002 Cr-Commit-Position: refs/heads/master@{#455316} Committed: https://chromium.googlesource.com/chromium/src/+/e4ff7160c06948baf8dd3d3141c00c8cee40fc3b

Patch Set 1 #

Patch Set 2 : update OWNERS #

Total comments: 1

Patch Set 3 : addressed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -310 lines) Patch
M content/browser/compositor/mus_browser_compositor_output_surface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/compositor/mus_browser_compositor_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/mus/renderer_window_tree_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/mus/renderer_window_tree_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/ui/public/cpp/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/public/cpp/OWNERS View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + services/ui/public/cpp/client_compositor_frame_sink.h View 4 chunks +15 lines, -15 lines 0 comments Download
A + services/ui/public/cpp/client_compositor_frame_sink.cc View 10 chunks +20 lines, -20 lines 0 comments Download
D services/ui/public/cpp/window_compositor_frame_sink.h View 1 chunk +0 lines, -103 lines 0 comments Download
D services/ui/public/cpp/window_compositor_frame_sink.cc View 1 chunk +0 lines, -152 lines 0 comments Download
M ui/aura/mus/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/mus/window_port_mus.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/aura/mus/window_port_mus.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Alex Z.
PTAL
3 years, 9 months ago (2017-03-07 15:33:32 UTC) #4
Fady Samuel
lgtm + nit. https://codereview.chromium.org/2732283002/diff/20001/services/ui/public/cpp/OWNERS File services/ui/public/cpp/OWNERS (right): https://codereview.chromium.org/2732283002/diff/20001/services/ui/public/cpp/OWNERS#newcode3 services/ui/public/cpp/OWNERS:3: per-file client_compositor_frame_sink*.*=fsamuel@chromium.org *compositor_frame_sink*.*
3 years, 9 months ago (2017-03-07 17:36:15 UTC) #5
Alex Z.
sky@: Please review changes in services/ui/public/cpp/BUILD.gn, services/ui/public/cpp/OWNERS and ui/aura/mus/
3 years, 9 months ago (2017-03-07 19:02:20 UTC) #7
sky
LGTM
3 years, 9 months ago (2017-03-07 22:05:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732283002/40001
3 years, 9 months ago (2017-03-07 22:20:07 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 01:09:42 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e4ff7160c06948baf8dd3d3141c0...

Powered by Google App Engine
This is Rietveld 408576698