Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Issue 2732223007: Revert of Combine 2 exclusions in Layout Opportunity Tree if they shadow each other (Closed)

Created:
3 years, 9 months ago by agrieve
Modified:
3 years, 9 months ago
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Combine 2 exclusions in Layout Opportunity Tree if they shadow each other (patchset #5 id:100001 of https://codereview.chromium.org/2733133002/ ) Reason for revert: Broke downstream bot (see bug) Original issue's description: > Combine 2 exclusions in Layout Opportunity Tree if they shadow each other > > This patch introduces the logic that tries to combine 2 exclusions if > possible. > We can combine 2 exclusions if > - they are adjoining to each other and have the same exclusion type > - the new exclusion shadows the old one. > That's because it's not allowed to position anything in the > shadowed area. > > Example: > <div id="SS" style="float: left; height: 10px; width: 10px"></div> > <div id="BB" style="float: left; height: 20px; width: 20px"></div> > +----------------+ > |SSBB > |**BB > We combine SS and BB exclusions including the shadowed area (**). > > BUG=635619 > TESTS=TwoRightExclusionsShadowEachOther, > TwoLeftExclusionsShadowEachOther > > Review-Url: https://codereview.chromium.org/2733133002 > Cr-Commit-Position: refs/heads/master@{#455444} > Committed: https://chromium.googlesource.com/chromium/src/+/5ccd9ec6998eee48bc73e7d8a992c4cccdb31899 TBR=ikilpatrick@chromium.org,cbiesinger@chromium.org,glebl@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619, 699703 Review-Url: https://codereview.chromium.org/2732223007 Cr-Commit-Position: refs/heads/master@{#455541} Committed: https://chromium.googlesource.com/chromium/src/+/ad9e2730b5bf41af6386f0526d5f901fb515258e

Patch Set 1 #

Messages

Total messages: 7 (4 generated)
agrieve
Created Revert of Combine 2 exclusions in Layout Opportunity Tree if they shadow each other
3 years, 9 months ago (2017-03-08 21:09:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732223007/1
3 years, 9 months ago (2017-03-08 21:10:41 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 21:13:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ad9e2730b5bf41af6386f0526d5f...

Powered by Google App Engine
This is Rietveld 408576698